-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 10 support #5753
base: 1.6
Are you sure you want to change the base?
Laravel 10 support #5753
Conversation
This looks dodgy...anyone tested successfuly? |
@mdenitti can you clarify what is that you find "dodgy" ? Like stated before, you can add comments if there's something wrong from your point of view. I must say that my auto-indent might have removed some spaces in the composer.json and phpunit.xml. Maybe this is what confuses you ? I can add some more explanations about how I solved the issue at the first place. The initial problem from the current state of the branch 1.6-l10 can be seen here: https://github.com/the-control-group/voyager/actions/runs/4080000210/jobs/7498342456?pr=5732.
It came from the following line of code: This Right now, Voyager Seeder system is based on Laravel <7 with In my PR, I removed all this, because Voyager is no more compatible for Laravel <7. I renamed |
Cleaning up UsersTableSeeder.php
@mdenitti I added a comment on each major changes for more clarity, to help the reviewer. Hope this helps. 👍 |
Jean! Wonderfull this looks much better; Genius... Merging still blocked???? We need L10 support now :))) |
Is it worth downgrading somehow to L9 from L10? Or there will be support soon? 😊 |
try this, worked for me on laravel 10 thank later |
Found 1 security vulnerability advisory affecting 1 package. Installation failed, reverting ./composer.json and ./composer.lock to their original content. |
How is this taking so long to get merged? It works! |
It looks like the-control-group do not intend to maintain the project any further. They have had no reaction since February, when I first mentioned the issue with Laravel 10. And also some links in the documentation no longer work. I think this repository will no longer be supported. Sad. |
@marktopper, @marktopper Hello, I hope both of you are alive. Could you please pay some attention here? |
Is this package no longer updated to support new versions of Laravel? |
This PR includes the last bits to make Voyager Laravel 10 compatible (work started there #5732 ).
Here's a breakdown of what I did:
getParameter
, closing json_decode(): Passing null to parameter #1 ($json) of type string is deprecated #5603seeds
folder and use theseeders
folder everywhere (Laravel 8+).This PR passes all the phpunit tests up until PHP 8.2 on my fork (https://github.com/jf-m/voyager/actions/runs/4600528910).
Any comments welcome, hope this helps !