Add JSR support #107
Add JSR support #107
Conversation
| @@ -0,0 +1,25 @@ | |||
| { | |||
| "name": "@bureaudouble-forks/react-remove-scroll", | |||
There was a problem hiding this comment.
not trying to be mean, I'm following multiple repo looking for new releases and many of them received similar PRs w/ same namespace and user, it does seem odd... but have no idea how deno actually works... you can see his other PRs: https://github.com/search?q=bureaudouble&type=pullrequests
There was a problem hiding this comment.
Thanks @maiconcarraro, I am really inclined to follow @joe-bell's example and close these multiple PRs (opened one day for multiple packages I maintain) without any explanation or link to get extra information from. And I cannot maintain what I do not understand in the details.
Hopefully, I am aware of what JSR is, but
bureaudouble? 🤷♂️- "zero major versions?" 🤷♂️
- "imports" 🤷♂️
- ESM support? 🤷♂️
// @deno-types=for some imports? 🤷♂️
What actually the fuck, and what actually the goal?
There was a problem hiding this comment.
I only found out after doing some further reading; bureaudouble is actually his personal account scope
This just feels like straight up spam to me
There was a problem hiding this comment.
I have made the required changes so that the package could be delivered in jsr.io. I thought it would be in the interest of the community to make it open, thus the PR.
I'm open to any constructive feedback, and I'm a bit disappointed by what you've written, mainly because you jumped straight to a conclusion without being willing to ask less aggressively for clarification. However, I acknowledge that I'm also part of the issue; I should have made my PR clearer in the first instance.
Regarding the bureaudouble-forks scope, please note that the jsr configuration file is only for reference. I use it on my personal scope because I needed it to be published. However, it should be replaced by a maintainer-owned scope. Perhaps I should have only created an issue instead of a PR. It's up to you to decide whether to use it, suggest improvements, or discard it entirely. I made these changes for my work, and the PR is currently a draft.
This is not spam. Many packages I need for my work have to be on JSR.io, and I was willing to share the edits I made with the community, also to push a release process on this registry. Nothing more.
Regarding the deno-types, they are specific to Deno. They are needed because React doesn't ship with native types, and Deno doesn't automatically look at the @DefinitelyTyped repository. See this issue:
facebook/react#28822
As stated in the PR, the JSR scope I use is only an example, and yes, bureaudouble-forks is the one I use because I own it. I will not create a scope in place of maintainers.
Regarding the fact that I added explicit extensions, it's because JSR.io doesn't accept sloppy imports. I don't understand why this change is not compatible with ESM modules. In fact, the opposite is true; sloppy imports are not part of the ESM spec, or else I'm mistaken.
I also thought that the reason for this PR would be to promote the use of this registry, which I believe is more modern. It aims to improve upon npm by providing native TypeScript support, focusing on ECMAScript modules, offering cross-runtime compatibility, and delivering an outstanding developer experience while ensuring fast, secure, and reliable package management.
Here is a link to the current documentation that I should have added: https://jsr.io/docs/publishing-packages
| import { IRemoveScrollProps, RemoveScrollType } from './types'; | ||
| import { RemoveScroll } from './UI.tsx'; | ||
| import SideCar from './sidecar.tsx'; | ||
| import { IRemoveScrollProps, RemoveScrollType } from './types.tsx'; |
There was a problem hiding this comment.
this change should be reflected in eslint configuration and this change is not compatible with ESM modules.
Please review my changes so it support deployment into the JSR registry. For example here is the JSR scope that use this PR: https://jsr.io/@bureaudouble-forks/react-remove-scroll