This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 29
Event ranking tabs sortable by rank, team, opr #376
Merged
Techno11
merged 7 commits into
the-orange-alliance:master
from
Wayne-King:rankings-sort
Dec 20, 2020
Merged
Event ranking tabs sortable by rank, team, opr #376
Techno11
merged 7 commits into
the-orange-alliance:master
from
Wayne-King:rankings-sort
Dec 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's embarrassing; I need to look into why my local build didn't catch that. |
Wayne-King
commented
Apr 8, 2020
src/app/views/event/subviews/event-rankings/event-rankings.component.ts
Outdated
Show resolved
Hide resolved
Review please, anyone? |
kyle-flynn
previously approved these changes
Jul 29, 2020
ofekashery
suggested changes
Jul 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you!
Can we make the button a bit smaller?
ofekashery
reviewed
Jul 29, 2020
ofekashery
approved these changes
Oct 4, 2020
Ping! |
Ping! :) |
I'll take a look at today when I get home today! Huge apologies for the wait. |
Techno11
approved these changes
Dec 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #338.