Feature/extend item crud operations #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge release 0.13
dpk
reviewed
Jan 9, 2025
| @@ -487,7 +487,7 @@ def search_objects( | |||
| size=20, | |||
| sort=None, | |||
| dso_type=None, | |||
| configuration='default', | |||
| configuration="default", | |||
There was a problem hiding this comment.
@kshepherd How much do we care about having a clean git blame?
I would strongly prefer at the very least that mere formatting changes like this be in their own commit. (I assume this is a black thing?)
| # Handle successful response | ||
| if response.status_code == 200: | ||
| # Parse the response JSON into an Item object | ||
| return self._construct_item(response.json()) |
There was a problem hiding this comment.
Oh: this is a breaking API change so we should bump to version 0.2 after merging this
|
Thanks for this! @kshepherd, who is the main maintainer of this library, is still on holiday right now, so it'll be another week or so yet before this gets approved, but I've noted one minor nit. I haven't fully reviewed and tested the new PATCH code yet but it looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request mainly addresses the Add dedicated patch and delete item functions issue #41
Please note: The pull request also includes an enhanced get_item Method in DSpaceClient, which returns an item object and handles errors. (see issue #29)
The modified the get_item method: