Issue#55: Style Home Page #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 80d3b75): https://tcl-77-smart-shopping-list--pr65-fz-design-homepage-hzadu9e3.web.app (expires Mon, 21 Oct 2024 21:36:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72 |
RossaMania
approved these changes
Oct 15, 2024
bbland1
reviewed
Oct 16, 2024
| {user && ( | ||
| <> | ||
| <ul> | ||
| <CreateList user={user} setListPath={setListPath} /> | ||
| <h3 className="heading-text">Your Lists</h3> |
There was a problem hiding this comment.
Nice add to have a way to show the user these are their lists!
bbland1
reviewed
Oct 16, 2024
| Learn More | ||
| </Button> | ||
| <SignInButton isSignIn={false} /> | ||
| <h3 className="heading-text">Welcome Back:</h3> |
There was a problem hiding this comment.
I love the seperation of the buttons here and switching the learn more to the below the sign back in button!
bbland1
reviewed
Oct 16, 2024
| @@ -0,0 +1,12 @@ | |||
| // ====== MEDIA ======== | |||
| @mixin tablet { | |||
There was a problem hiding this comment.
so these are mixins how cool!
bbland1
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of how to fill this template out, see this Pull Request.
Description
Designed the HomePage views for Unauthenticated and Authenticated audience referencing the teams' figma design. Adjusted some of the default styling coming in from React Bootstrap elements to ensure they align with our design requirements.
Related Issue
Closes #55
Acceptance Criteria
Type of Changes
designUI updatesUpdates
Before
After
Unauthenticated HomePage:
Authenticated HomePage:
Testing Steps / QA Criteria