Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #21: Implement TailwindCSS for ManageList page, refactor naming to AddItem page and modal close for Create List. #59

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

shuveksha-tuladhar
Copy link
Collaborator

Description

This PR implements TailwindCSS for the ManageList page and renames the component and routes to AddItem.

  • Route changed to add-item.
  • Component renamed to AddItem.
  • Create List modal closes after entry.
  • Radio button enhancement.

Related Issue

Type of Changes

enhancement
bug fix
refactoring

Updates

After

image

Copy link

github-actions bot commented Oct 9, 2024

Visit the preview URL for this PR (updated for commit 1bbe3db):

https://tcl-74-smart-shopping-list--pr59-st-managelist-j17utxfb.web.app

(expires Wed, 16 Oct 2024 23:38:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 79d73546692f99aad8468c28e36db434e2c190ac

@shuveksha-tuladhar shuveksha-tuladhar marked this pull request as ready for review October 9, 2024 22:54
Copy link
Member

@dterceroparker dterceroparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buttons looks stunning! Wow! Everything works well for me on AddItem page. However, create list modal doesn't close after entry but maybe code hasn't updated on my end. I'm approving it. Great work!

@shuveksha-tuladhar shuveksha-tuladhar changed the title Issue #21: Implement TailwindCSS for c, refactor naming to AddItem page and modal close for Create List. Issue #21: Implement TailwindCSS for ManageList page, refactor naming to AddItem page and modal close for Create List. Oct 10, 2024
Copy link
Collaborator

@NickRoccodev11 NickRoccodev11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, i like the gradients on buttons!

@shuveksha-tuladhar shuveksha-tuladhar merged commit 4920011 into main Oct 10, 2024
2 checks passed
@shuveksha-tuladhar shuveksha-tuladhar deleted the st-managelist branch October 10, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

21. Implement TailwindCSS on ManageList page and renamed it to be AddItem page.
4 participants