Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logo and name app #75

Merged
merged 2 commits into from
Apr 4, 2024
Merged

add logo and name app #75

merged 2 commits into from
Apr 4, 2024

Conversation

ocsiddisco
Copy link
Collaborator

Description

This PR adds the new name of the app and a new favicon.
Note: the original font size of the name was not fitting the new name. The font size of the app name is increased.

Type of Changes

enhancement

Updates

Before

Screenshot 2024-04-03 215121

Screenshot 2024-04-03 215116

After

Screenshot 2024-04-03 213824

Screenshot 2024-04-03 212545

Screenshot 2024-04-03 212533

Testing Steps / QA Criteria

-git checkout -b name-app
-git pull origin name-app
You can controle the responsiveness of the navigation with the new name and the display of the favicon.

Copy link

github-actions bot commented Apr 3, 2024

Visit the preview URL for this PR (updated for commit 8dcfb8f):

https://tcl-71-smart-shopping-list--pr75-name-app-bo24i9ff.web.app

(expires Thu, 11 Apr 2024 00:02:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e7ade9d0f374c4ddb5d7ab6fc541062fc7a1ab4

Copy link
Collaborator

@vivitt vivitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @ocsiddisco !

Copy link
Collaborator

@borjaMarti borjaMarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ocsiddisco!!

It looks awesome with the extended version on desktop 🔥🔥

I pushed a commit changing the title from the landing as well. Left the rest of the text as it was because I didn't know how to make the slogan "un-think your pantry" fit/sound good 😆

Copy link
Collaborator Author

@ocsiddisco ocsiddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this one and update it!

@ocsiddisco ocsiddisco requested a review from elitcenk April 4, 2024 06:32
@ocsiddisco ocsiddisco merged commit 6e610ee into main Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants