Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KD] Add screenshots of app on About page #92

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Conversation

piecanoe
Copy link
Collaborator

@piecanoe piecanoe commented Apr 6, 2024

Description

This code replaces the temp phone images on the About page with screenshots of the application to help the user learn how to use the app.

Related Issue

Closes #91

Acceptance Criteria

  • Swap out the temporary blank phone images with images of screenshots of the app

Type of Changes

Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g., bug fix or enhancement are common ones.

Updates

Before

before

After

after

Testing Steps / QA Criteria

Navigate to the About page. Scroll down to see that all temp phone images have been replaced with screenshots from the application that compliment the instructions.

@piecanoe piecanoe self-assigned this Apr 6, 2024
@piecanoe piecanoe marked this pull request as ready for review April 6, 2024 17:03
@piecanoe piecanoe added the design sprint design sprint from issue 14 label Apr 6, 2024
Copy link

github-actions bot commented Apr 6, 2024

Visit the preview URL for this PR (updated for commit 68b8881):

https://tcl-69-smart-shopping-list--pr92-kd-add-screenshots-g2765yry.web.app

(expires Sat, 13 Apr 2024 17:04:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80

Copy link
Collaborator

@amalyam amalyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic!
(side note - idk if it's just me, but I'm having trouble logging in on the preview link for this PR. don't think it's anything you did, but not sure why it's happening here and not on other PRs)

@piecanoe piecanoe merged commit e4299d1 into main Apr 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design sprint design sprint from issue 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace temp phone images with screenshots on About page
2 participants