Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic conditional styling for logged out users #66

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

andiedoescode
Copy link
Collaborator

Description

  • Added conditional styling to Home (hid new list form), List, and Manage List pages when a user is logged out. Improves user experience.
  • Adjusted ListHeader padding for small screens

Related Issue

N/A

Acceptance Criteria

N/A

Type of Changes

enhancement

Updates

Before

Home view
image

List & Manage List view
image

ListHeader padding
image

After

Home view
image

List view
image

Manage List view
image

ListHeader padding
image

Testing Steps / QA Criteria

  • Open deployment link or pull branch ap-logged-out.
  • Confirm that you are signed out.
  • Clear local storage to ensure there is no list path.
  • Navigate to the Home, List, and ManageList pages and verify that they look like the screenshots.
  • Navigate to List or ManageList page and sign in.
  • Verify that the header looks like the screenshot.
  • To double check that the conditional logic still works:
    • Navigate to Home page and select a list.
    • Verify that the List page looks as it did before with all components rendered.

Copy link

github-actions bot commented Apr 9, 2024

Visit the preview URL for this PR (updated for commit d1552c2):

https://tcl-68-smart-shopping-list--pr66-ap-logged-out-ktvmy4n9.web.app

(expires Tue, 16 Apr 2024 16:59:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8cb5d089a99ba9972009993f4dd31796b0cbda84

@andiedoescode andiedoescode marked this pull request as ready for review April 9, 2024 16:59
Copy link
Collaborator

@sdmisra sdmisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'll follow this style overall to complete the issue @andiedoescode and I spoke about this morning (4/9) : the about section with links to our devs, mentors, and TCL.

@andiedoescode andiedoescode merged commit e9c1afa into main Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants