Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm dg style header navigation #62

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Conversation

sdmisra
Copy link
Collaborator

@sdmisra sdmisra commented Apr 4, 2024

Description

This PR adds styling to our header and navbar at the bottom of the app, according to our prototype / mockup styling.

Related Issue

Closes Issue #57

Acceptance Criteria

  • Logo/Header
  • Navigation Bar
  • Buttons: Navigation Bar
  • (After Sign In) Header text: Signed in As
  • (After Sign In) Button: Sign Out

Type of Changes

enhancement

Updates

Before

Screenshot 2024-04-03 at 8 04 22 PM

After

image

Testing Steps / QA Criteria

  1. Navigate to deployment below
  2. Confirm that header, logo and nav buttons are in same style as

Note: There is spacing added to the 'Signed in as' and button next to it on our other PR (home page styling) as well as the background color changed to eggshell on the body as well (those changes not represented in these screenshots).

Copy link

github-actions bot commented Apr 4, 2024

Visit the preview URL for this PR (updated for commit 465c131):

https://tcl-68-smart-shopping-list--pr62-sm-dg-style-header-n-iz0izrev.web.app

(expires Fri, 12 Apr 2024 22:44:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8cb5d089a99ba9972009993f4dd31796b0cbda84

Copy link
Collaborator

@andiedoescode andiedoescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking great! Cant' wait to see the other styling you guys did integrated together with this batch.

Thought: We'll need to incorporate the text-off-black into our end of the styling for consistency. It's certainly nicer than black black.

public/img/basket-buddy-logo.png Outdated Show resolved Hide resolved
Copy link
Collaborator

@etiry etiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

public/img/basket-buddy-logo.png Outdated Show resolved Hide resolved
src/views/Layout.jsx Show resolved Hide resolved
@DevinaG007 DevinaG007 merged commit e0388fa into main Apr 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants