Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Padding fix #63

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Nav Padding fix #63

merged 2 commits into from
Apr 5, 2024

Conversation

eonflower
Copy link
Collaborator

Description

Updated padding/styling to keep the list components inside the nav bar.

Type of Changes

enhancement

Updates

Before

Screenshot 2024-04-05 at 12 12 24 AM

After

Screenshot 2024-04-05 at 12 12 38 AM

Testing Steps / QA Criteria

  1. git pull from main
  2. git checkout an-nav-padding
  3. see that lists in the nav bar are confined to the nav bar instead of leaking out and covering the right border line of the nav

@eonflower eonflower added the enhancement New feature or request label Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Visit the preview URL for this PR (updated for commit d93ed78):

https://tcl-66-smart-shopping-list--pr63-an-nav-padding-o01b8hmx.web.app

(expires Fri, 12 Apr 2024 07:17:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2dc16cb2a79cbd6723fdc511b73e0743df1d18d0

Copy link
Collaborator

@jeremiahfallin jeremiahfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@eonflower eonflower merged commit 2b76618 into main Apr 5, 2024
2 checks passed
@eonflower eonflower deleted the an-nav-padding branch April 5, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants