Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add welcoming prompt #20

Merged
merged 5 commits into from
Apr 29, 2023
Merged

Add welcoming prompt #20

merged 5 commits into from
Apr 29, 2023

Conversation

ToobaJamal
Copy link
Collaborator

@ToobaJamal ToobaJamal commented Apr 23, 2023

Co-authored-by: [email protected]

Description

This change adds a welcoming prompt on the List page. If the user goes to the List page with no list token saved in local storage, an Add item button is displayed on the screen. Clicking on the Add item button takes the user to the add-item page.

Related Issue

Closes #7

Acceptance Criteria

  • The list view, when there are no items to display, should show a prompt (e.g., a button) for the user to add their first item

Type of Changes

Type
πŸ› Bug fix
βœ“ ✨ New feature
πŸ”¨ Refactoring
πŸ’― Add tests
πŸ”— Update dependencies
πŸ“œ Docs

Updates

Before

issue7_before.mp4

After

issue7_after.mp4

Testing Steps / QA Criteria

  1. Run git checkout tj-la-new-list-welcome-message
  2. Run npm start
  3. Verify if the List page shows an Add item button which takes you to the add-item page when there is no saved list in your browser

Co-authored-by: Laura Abro <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 23, 2023

Visit the preview URL for this PR (updated for commit c860b79):

https://tcl-60-smart-shopping-list--pr20-tj-la-new-list-welco-botvyzmi.web.app

(expires Sat, 06 May 2023 15:38:31 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: 93ba99965233232f14cf05d9d95de4adc510bd3b

@ToobaJamal ToobaJamal marked this pull request as ready for review April 26, 2023 14:33
@RajGM
Copy link
Collaborator

RajGM commented Apr 27, 2023

Hi, @ToobaJamal and @labrocadabro
The prompt is not showing up in the preview link.

@ToobaJamal
Copy link
Collaborator Author

Hi, @ToobaJamal and @labrocadabro The prompt is not showing up in the preview link.

Hi Raj,

I just checked it and its working on my browser. @labrocadabro, could you please confirm?

welcoming_prompt.mp4

@labrocadabro
Copy link
Collaborator

I also checked from the preview link and it seems to be fine.

Screen.Recording.2023-04-28.at.6.40.34.AM.mov

@RajGM
Copy link
Collaborator

RajGM commented Apr 29, 2023

Working on mine as well.

Copy link
Member

@paramsiddharth paramsiddharth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, Tooba and Laura! :)

@paramsiddharth paramsiddharth merged commit 6838822 into main Apr 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants