Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change ListItem disablePadding value from string to Boolean #58

Merged
merged 1 commit into from May 28, 2023

Conversation

jongranados
Copy link
Collaborator

For an example of how to fill this template out, see this Pull Request.

Description

The disablePadding prop in ListItem expects a Boolean but was receiving a string.

Related Issue

Acceptance Criteria

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ’― Add tests
πŸ”— Update dependencies
πŸ“œ Docs

Updates

Before

After

Testing Steps / QA Criteria

@jongranados jongranados marked this pull request as ready for review May 28, 2023 19:57
@jongranados jongranados merged commit 9e625ef into main May 28, 2023
3 checks passed
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 5ab38a9):

https://tcl-57-smart-shopping-list--pr58-jg-fix-type-of-prop-80c1sk46.web.app

(expires Sun, 04 Jun 2023 19:58:09 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: ad3eb6c34c2ec5986fcc218178df5985eb9c9ffb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant