Continue styling home page #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit dd9a6e5): https://tcl-57-smart-shopping-list--pr55-continue-styling-hom-eel1r5vd.web.app (expires Sun, 04 Jun 2023 03:23:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ad3eb6c34c2ec5986fcc218178df5985eb9c9ffb |
Amy-Pr
approved these changes
May 28, 2023
There was a problem hiding this comment.
Hi Jon, it looks good! I like what you did with the token input. I think we might need a little padding or margin or something at the bottom of the page, under the Join List button since it ends abruptly without any white space. That might be something that can be added to the outer container in the Layout too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of how to fill this template out, see this Pull Request.
Description
This PR completes the layout and styling of the Home Page.
Related Issue
closes #41
Acceptance Criteria
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria