Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passed listToken to AddItem component #20

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Passed listToken to AddItem component #20

merged 1 commit into from
Apr 21, 2023

Conversation

Amy-Pr
Copy link
Collaborator

@Amy-Pr Amy-Pr commented Apr 19, 2023

Description

This fix replaces the test list so that individual users can create their own lists. Their items will get added to correct lists from the input feature in Add Item view.

Related Issue

closes #19

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
💯 Add tests
🔗 Update dependencies
📜 Docs

Updates

Before

Before passing the listToken, 'my test list' rendered in the 'List' view.

before-image

After

After passing the token, the user makes a 'new list' from the home page, creating the new token, and can start adding items from 'Add Item' view into their own list.

After-image

Testing Steps / QA Criteria

  • Start a new list from Home
  • Check that new token was created under Application in browser developer tools
  • Navigate to Add Items and start adding items
  • Check that they are added to List view

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 8be3217):

https://tcl-57-smart-shopping-list--pr20-ap-pass-token-list-pn1bofy2.web.app

(expires Wed, 26 Apr 2023 01:37:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ad3eb6c34c2ec5986fcc218178df5985eb9c9ffb

Copy link
Collaborator

@emilysellers emilysellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - nice work!

Copy link
Contributor

@bethmelmtv bethmelmtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work Amy!

Copy link
Collaborator

@danainjax danainjax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, Amy!

@Amy-Pr Amy-Pr merged commit f27028d into main Apr 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically pass in the list token to make sure items are added to the right list.
5 participants