Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comprehensive refactor of functions dealing with dates and tests reduction #40

Merged
merged 7 commits into from
May 24, 2023
Merged

Comprehensive refactor of functions dealing with dates and tests reduction #40

merged 7 commits into from
May 24, 2023

Commits on May 23, 2023

  1. refactor: round up with Math.ceil instead of round down for more accu… 

    …rate urgency label on list items
    @yiremorlans
    yiremorlans committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8dfda96 View commit details
    Browse the repository at this point in the history

  2. refactor: edit tests to remove hard coded expected values and to calc… 

    …ulate for dates rounding up
    @yiremorlans
    yiremorlans committed May 23, 2023
    Configuration menu
    Copy the full SHA
    13ff648 View commit details
    Browse the repository at this point in the history

  3. refactor: edit purchaseUrgencyMessage for more clarity on if statemen… 

    …ts and delete extra date calculating functions
    @yiremorlans
    yiremorlans committed May 23, 2023
    Configuration menu
    Copy the full SHA
    56c1ec3 View commit details
    Browse the repository at this point in the history

  4. refactor: delete extra date calculating functions and utilized getDay… 

    …sBetweenDates for comparing purchase urgency
    @yiremorlans
    yiremorlans committed May 23, 2023
    Configuration menu
    Copy the full SHA
    837ca6c View commit details
    Browse the repository at this point in the history

  5. delete not yet purchased label from legend

    @yiremorlans
    yiremorlans committed May 23, 2023
    Configuration menu
    Copy the full SHA
    91a57e1 View commit details
    Browse the repository at this point in the history

  6. delete tests for functions no longer used

    @yiremorlans
    yiremorlans committed May 23, 2023
    Configuration menu
    Copy the full SHA
    acdac9c View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Merge branch 'main' into ym-dates-refactor

    @yiremorlans
    yiremorlans committed May 24, 2023
    Configuration menu
    Copy the full SHA
    6cb9e6b View commit details
    Browse the repository at this point in the history