Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font style and color #36

Merged
merged 4 commits into from May 24, 2023
Merged

Update font style and color #36

merged 4 commits into from May 24, 2023

Conversation

drakenguyen4000
Copy link
Collaborator

@drakenguyen4000 drakenguyen4000 commented May 23, 2023

Description

Updates the font style and color to make app looking for polished and professional.

Related Issue

#35

Acceptance Criteria

  • Font family needs be changed.
  • Font color needs update.
  • Extra: Change color of legend icon to skyblue.
  • Fix Bug: Ensure that when there is no list present, the user cannot navigate to Add Item page.
  • Change the legend to Kinda Soon and Not Soon to match labels.

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
💯 Add tests
🔗 Update dependencies
📜 Docs

Updates

Before

image

After

image
image
image

Testing Steps / QA Criteria

@github-actions
Copy link

github-actions bot commented May 23, 2023

Visit the preview URL for this PR (updated for commit 861b8f9):

https://tcl-56-smart-shopping-li-ffe7d--pr36-dn-stylize-fonts-xcihl1hk.web.app

(expires Wed, 31 May 2023 14:57:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9c51cec5927ae3f1253a2134be95c1a07393f9a7

@drakenguyen4000 drakenguyen4000 self-assigned this May 23, 2023
@drakenguyen4000 drakenguyen4000 added bug Something isn't working enhancement New feature or request labels May 23, 2023
Copy link
Collaborator

@yiremorlans yiremorlans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this PR has similar changes to the other PR. I think the colors pass but I would like the font style to be addressed. I approve all the other changes.

@drakenguyen4000
Copy link
Collaborator Author

I made the changes to make the fonts more web accessible to this pull request.

@yiremorlans yiremorlans merged commit f56fea2 into main May 24, 2023
2 checks passed
@yiremorlans yiremorlans deleted the dn-stylize-fonts branch May 24, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants