Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onChange now clears submit message #34

Merged
merged 1 commit into from May 20, 2023
Merged

Conversation

ashleyvalentine
Copy link
Collaborator

@ashleyvalentine ashleyvalentine commented May 20, 2023

Description

The success and error messages that display in the AddItem view now clear when the user changes the input.

Related Issue

closes #29

Acceptance Criteria

  • The success and error messages in AddItem should disappear when the user changes the input.

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ’― Add tests
πŸ”— Update dependencies
πŸ“œ Docs

 if submit message exists
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 8e0b1f0):

https://tcl-56-smart-shopping-li-ffe7d--pr34-av-success-error-7sfhav5v.web.app

(expires Sat, 27 May 2023 12:16:21 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: 9c51cec5927ae3f1253a2134be95c1a07393f9a7

Copy link
Collaborator

@yiremorlans yiremorlans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvements are pretty straightforward to me. Thanks for fixing that bug.

@DwightTheShark DwightTheShark merged commit 38af4d1 into main May 20, 2023
2 checks passed
@yiremorlans yiremorlans deleted the av-success-error-messages branch May 20, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants