Ym av render names of list #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 4562c0b): https://tcl-56-smart-shopping-li-ffe7d--pr17-ym-av-render-name-lnt9jmxb.web.app (expires Tue, 11 Apr 2023 14:40:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9c51cec5927ae3f1253a2134be95c1a07393f9a7 |
yiremorlans
reviewed
Apr 4, 2023
There was a problem hiding this comment.
Add .vscode to gitignore to prevent local vscode config push to repository. Clean up comments.
Located where data was being sent from API and functions in App.jsx responsible for sending data as a prop to the ListItem component.
Render the list of names using the database's unique ID as a key and name property for the list item.
drakenguyen4000
approved these changes
Apr 5, 2023
|
Item names are rendered on the list page. The code looks clean. Great job! |
yiremorlans
approved these changes
Apr 5, 2023
adidalal
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of how to fill this template out, see this Pull Request.
Description
We worked on the List component so that it renders each list item from the database. Map is a standard approach to rendering lists of items from an array.
Related Issue
Closes #1
Acceptance Criteria
[x] The streamListItems function is used in App.jsx to get the items in the current list from the Firestore database
[x] The list is passed into the List component as a prop named data
[x] In List.jsx, the ListItem component is used to render the name of each item
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria