New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds about page #44
Adds about page #44
Conversation
Visit the preview URL for this PR (updated for commit 759099e): https://tcl-55-smart-shopping-list--pr44-tf-jf-about-drawer-db40z96d.web.app (expires Sun, 04 Jun 2023 23:36:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 607d14028385ebfcc7c9ec69a7bb14d95ed54078 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great both on desktop and mobile. Main change are the typos, the rest are just me trying to understand the deviation from the wireframe and our convo during OH.
src/views/Layout.jsx
Outdated
<Heading as="button" onClick={onOpen} cursor={'pointer'}> | ||
Smart shopping list | ||
<VisuallyHidden>Open about modal</VisuallyHidden> | ||
</Heading> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I read our PR description, I was initially confused where we could find the about page. We spoke during OH about using a button above the add items button. Are we able to use that, just because its clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was looking cluttered at the top of the app with both of the buttons (adding an item and also learning about the app) so we went with a subtle easter egg instead. We added the a cursor when you hover over the title and talked about also changing the title color on hover as clues that it is clickable.
<Text>{name}</Text> | ||
<Link to={github}> | ||
<Icon as={Github} /> | ||
</Link> | ||
<Link to={linkedin}> | ||
<Icon as={Linkedin} /> | ||
</Link> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also left out photos for the same clutter reason as the button. If you add more to the about drawer you have to scroll. Right now everything fits without having to scroll even on really small devices. We can add them if we really want them but we also all have pictures on our LinkedIns.
Description
This code adds an about page to give a brief description of the app, link to the developers' websites, and credit the Home page logo. It is accessible by clicking on the List Luxe title.
Related Issue
Closes #40
Acceptance Criteria
Type of Changes
Updates
After
Testing Steps / QA Criteria
In your terminal, use
git checkout tf-jf-about drawer
to create a new branch and switch over.Use
git pull origin tf-jf-about drawer
to bring the changes from remote to local.npm start to start a local instance of our app