Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds about page #44

Merged
merged 6 commits into from May 28, 2023
Merged

Adds about page #44

merged 6 commits into from May 28, 2023

Conversation

ticiadev
Copy link
Collaborator

@ticiadev ticiadev commented May 25, 2023

Description

This code adds an about page to give a brief description of the app, link to the developers' websites, and credit the Home page logo. It is accessible by clicking on the List Luxe title.

Related Issue

Closes #40

Acceptance Criteria

  • Create the About page following the wireframe in the notes
    • Create a section about the app and how to use it
    • Create a section with a brief bio on each developer that worked on it along with their photos and social links
  • Add this page to the home and list pages using a drawer

Type of Changes

Type
✨ New feature

Updates

After

image

Testing Steps / QA Criteria

In your terminal, use git checkout tf-jf-about drawer to create a new branch and switch over.
Use git pull origin tf-jf-about drawer to bring the changes from remote to local.
npm start to start a local instance of our app

  • Open the drawer from the Home page by clicking on the title and confirm that the Add Item page is displayed within it
  • Test the drawer accessibility by opening and closing it using both keyboard and mouse

@github-actions
Copy link

github-actions bot commented May 25, 2023

Visit the preview URL for this PR (updated for commit 759099e):

https://tcl-55-smart-shopping-list--pr44-tf-jf-about-drawer-db40z96d.web.app

(expires Sun, 04 Jun 2023 23:36:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 607d14028385ebfcc7c9ec69a7bb14d95ed54078

@ticiadev ticiadev marked this pull request as ready for review May 26, 2023 04:41
Copy link
Collaborator

@Yaosaur Yaosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great both on desktop and mobile. Main change are the typos, the rest are just me trying to understand the deviation from the wireframe and our convo during OH.

src/components/About.jsx Outdated Show resolved Hide resolved
Comment on lines 24 to 27
<Heading as="button" onClick={onOpen} cursor={'pointer'}>
Smart shopping list
<VisuallyHidden>Open about modal</VisuallyHidden>
</Heading>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I read our PR description, I was initially confused where we could find the about page. We spoke during OH about using a button above the add items button. Are we able to use that, just because its clearer?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was looking cluttered at the top of the app with both of the buttons (adding an item and also learning about the app) so we went with a subtle easter egg instead. We added the a cursor when you hover over the title and talked about also changing the title color on hover as clues that it is clickable.

Comment on lines +21 to +27
<Text>{name}</Text>
<Link to={github}>
<Icon as={Github} />
</Link>
<Link to={linkedin}>
<Icon as={Linkedin} />
</Link>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the AC, I was originally expecting photos for each of us. Was there a reason why that was scrapped?
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also left out photos for the same clutter reason as the button. If you add more to the about drawer you have to scroll. Right now everything fits without having to scroll even on really small devices. We can add them if we really want them but we also all have pictures on our LinkedIns.

@jeremiahfallin jeremiahfallin merged commit ef2945c into main May 28, 2023
2 checks passed
@jeremiahfallin jeremiahfallin deleted the tf-jf-about-drawer branch May 28, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

21. As a user, I want to learn about the app in a dedicated page
3 participants