-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make things pretty #67
Changes from 28 commits
0e910ae
8e929d3
2006904
ebfec3f
8760625
e3ae5e5
c2492ce
e6f9df9
90cb1c9
6c82e54
98cbab7
59cc12f
6162dfe
8794551
d7020fc
6faaeea
1d0b3a1
3281efc
875a252
16dddc0
9e6bf03
888ea52
c15135a
110f0bf
e74f67a
8d9ae51
581bafa
7a04c57
ba5596d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module.exports = { | ||
plugins: [{ plugin: require('@semantic-ui-react/craco-less') }], | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,10 +5,7 @@ | |
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
<meta name="theme-color" content="#000000" /> | ||
<meta | ||
name="description" | ||
content="Web site created using create-react-app" | ||
/> | ||
<meta name="description" content="Smart Shopping List" /> | ||
<link rel="apple-touch-icon" href="logo192.png" /> | ||
<!-- | ||
manifest.json provides metadata used when your web app is installed on a | ||
|
@@ -24,7 +21,7 @@ | |
work correctly both with client-side routing and a non-root public URL. | ||
Learn how to configure a non-root public URL by running `npm run build`. | ||
--> | ||
<title>React App</title> | ||
<title>Smart Shopping List - TCL3</title> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice job catching this detail! |
||
</head> | ||
<body> | ||
<noscript>You need to enable JavaScript to run this app.</noscript> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"short_name": "React App", | ||
"name": "Create React App Sample", | ||
"short_name": "Smart Shopping List", | ||
"name": "Smart Shopping List - Collab Lab Cohort 3", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Love that you took the time to tidy up these details! |
||
"icons": [ | ||
{ | ||
"src": "favicon.ico", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,3 @@ | ||
.App { | ||
text-align: center; | ||
} | ||
|
||
.App-logo { | ||
height: 40vmin; | ||
} | ||
|
||
.App-header { | ||
background-color: #282c34; | ||
min-height: 100vh; | ||
display: flex; | ||
flex-direction: column; | ||
align-items: center; | ||
justify-content: center; | ||
font-size: calc(10px + 2vmin); | ||
color: white; | ||
} | ||
|
||
.App-link { | ||
color: #09d3ac; | ||
header > h1 { | ||
font-size: 1.6rem; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
import React from 'react'; | ||
import AppRouter from './AppRouter'; | ||
import './App.css'; | ||
|
||
function App() { | ||
return ( | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import React from 'react'; | ||
import { Header, Segment, Button } from 'semantic-ui-react'; | ||
import { Link } from 'react-router-dom'; | ||
|
||
function AppHeader(props) { | ||
return ( | ||
<Segment textAlign="center" style={{ borderRadius: 0 }}> | ||
{props.showBackArrow && ( | ||
<> | ||
<Button | ||
style={{ marginRight: '-37.5px' }} | ||
basic | ||
as={Link} | ||
to="/" | ||
icon="arrow left" | ||
size="medium" | ||
color="blue" | ||
circular | ||
floated="left" | ||
></Button> | ||
{/* <Divider hidden /> */} | ||
</> | ||
)} | ||
|
||
<header> | ||
{/* <Image | ||
src={Logo} | ||
centered | ||
size="tiny" | ||
verticalAlign="middle" | ||
alt="Shopping List" | ||
/> */} | ||
<Header as="h1"> | ||
<Header.Content>{props.children}</Header.Content> | ||
</Header> | ||
</header> | ||
</Segment> | ||
); | ||
} | ||
AppHeader.defaultProps = { | ||
showBackArrow: false, | ||
}; | ||
export default AppHeader; |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
//normalized function | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
const normalizeName = name => { | ||
return name | ||
.replace(/[,.;:!-?]/g, '') | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this to allow overriding some of semantic ui's
less
styling?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the Semantic UI docs recommended craco so that the app doesn't eject when the less for the custom theme compiles. I'm not too familiar with that but that's how I understood it.
https://react.semantic-ui.com/theming/