Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: npm audit, remove databaseURL from firebaseConfig #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thetrend
Copy link
Sponsor Contributor

@thetrend thetrend commented Nov 12, 2023

For an example of how to fill this template out, see this Pull Request.

Description

After running npm ci on a fresh copy of this repo, there were some npm audit recommendations. I ran npm audit fix as recommended to clean up and remove any vulnerabilities.

I also removed databaseURL from firebaseConfig as the current template from Firebase no longer has that line and if left in, it might be confusing for collabies.

Related Issue

Acceptance Criteria

  • npm ci should produce no existing vulnerabilities
  • the app should function as normal

Type of Changes

Type
πŸ› Bug fix
✨ New feature
βœ“ πŸ”¨ Refactoring
πŸ’― Add tests
βœ“ πŸ”— Update dependencies
πŸ“œ Docs

Updates

Before

After

Testing Steps / QA Criteria

  1. npm ci should produce no existing vulnerabilities
  2. the app should function as normal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant