Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directional attacking now includes adjacent tiles #17286

Closed
wants to merge 3 commits into from

Conversation

lKiseki
Copy link
Contributor

@lKiseki lKiseki commented Mar 4, 2025

About The Pull Request

  • Directional attacks will now include adjacent tiles. In order for this condition to work, the user must be on harm intent, and be targeting the specific tile.
  • Adds a new signal, COMSIG_MOB_ATTACK_UNARMED, called by the UnarmedAttack proc.
  • Some of UnarmedAttack's child procs now call parent. Exceptions are made for xeno larvae, the hivemind, A.I., and simple animals.

Why It's Good For The Game

Makes targeting easier for players, and less of a sprite hunt.

Changelog

🆑 Lewdcifer
add: Directional attacking now affects adjacent tiles.
/:cl:

@github-actions github-actions bot added the Feature New interesting mechanics with new interesting bugs label Mar 4, 2025
@OmegaDarkPotato
Copy link

OmegaDarkPotato commented Mar 5, 2025

Doesn't this effectively turn all xeno attacks into 3x1s? Unless I'm misinterpreting the intent of this PR this seems like a pretty humongous buff

Copy link
Contributor

@Lumipharon Lumipharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really stinky.
unarmedattack is a proc for when you're already specifically clicking on something to hit it, yet you're just strapping a signal to it, to ultimately call THE SAME PROC the signal is coming from, without changing base behavior?

@Lumipharon Lumipharon added the Do Not Merge Pull request should not be merged due to design conflict or being a temporary change. label Mar 5, 2025
@lKiseki lKiseki closed this Mar 6, 2025
@lKiseki lKiseki deleted the dirattackfix branch March 6, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Pull request should not be merged due to design conflict or being a temporary change. Feature New interesting mechanics with new interesting bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants