-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some LOOC/Mentor-related tweaks #16969
Open
Neocloudy
wants to merge
4
commits into
tgstation:master
Choose a base branch
from
Neocloudy:actual-mentor-spying
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taff LOOC, tooltips in GameSettings.tsx, new looc color, mentor PMs look how they should, msay says that it's msay to avoid confusion
Barnet2
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine on headmin/headmentor side of things
we do not have a tweak: tag anymore fix your cl |
it seemed to exist when i checked changelog react-side code wtf... idk what to replace it with |
TiviPlus
added
Sound
Sound change.
Fix
Fixes an issue with the game.
Quality of Life
Minor changes that make the game nicer to play
labels
Jan 24, 2025
Lumipharon
added
the
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
label
Jan 27, 2025
Lumipharon
approved these changes
Jan 27, 2025
Let mentors mooc and xooc at any time pls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Administration
Alters the administrative tools used in-game.
Fix
Fixes an issue with the game.
Quality of Life
Minor changes that make the game nicer to play
Sound
Sound change.
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Mentor ghosts may now hear LOOC (incl. ckey/JMP/FLW) from anywhere. There's also a preference for staff in general to not spy on LOOC. LOOC also outputs in runechat!
On dark mode, mentor OOC is darker and LOOC has a new color.
On both themes, tooltips will color themselves to the span they're in (so this doesn't apply to examine tags, unfortunately).
Mentor PMs will not be super small anymore.
Mentorsay will be prefixed with "MENTOR:" to avoid confusion.
When an admin ticket is turned into a mentor ticket, it won't play the admin bwoink sound.
Why It's Good For The Game
Leads appear to have okayed this. New players tend to put their first questions in LOOC, this makes it easier for mentors to catch wind of questions in LOOC and point them in the right direction. Also I want more opportunities to initiate tickets with new players.
Makes LOOC easier for everyone else to notice without looking in chat. Even if a Mentor/Admin doesn't notice what you're saying, another player might. Also might encourage LOOC usage in place of saying "this stupid fucking PR" in character.
People (including me) keep confusing mentor OOC with common radio because it's too bright.
Also Lumi kept yelling at me to make msay properly tagged.
Changelog
🆑
admin: Mentor ghosts may now see LOOC from anywhere.
admin: Staff may turn off LOOC spying in preferences.
qol: LOOC now outputs in runechat.
qol: Mentor OOC is slightly darker.
qol: Msay is now tagged with "MENTOR:" to reduce confusion for admins.
soundadd: Admin tickets turned into mentor tickets will not play the admin bwoink sound, instead using the mentor bwoink sound.
fix: Mentor PMs will not be super small anymore.
/:cl: