Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some LOOC/Mentor-related tweaks #16969

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Neocloudy
Copy link
Contributor

@Neocloudy Neocloudy commented Jan 22, 2025

About The Pull Request

Mentor ghosts may now hear LOOC (incl. ckey/JMP/FLW) from anywhere. There's also a preference for staff in general to not spy on LOOC. LOOC also outputs in runechat!

On dark mode, mentor OOC is darker and LOOC has a new color.

On both themes, tooltips will color themselves to the span they're in (so this doesn't apply to examine tags, unfortunately).

Mentor PMs will not be super small anymore.

Mentorsay will be prefixed with "MENTOR:" to avoid confusion.

When an admin ticket is turned into a mentor ticket, it won't play the admin bwoink sound.

Why It's Good For The Game

Mentor ghosts may now hear LOOC (+ ckeys/JMP/FLW) from anywhere.

Leads appear to have okayed this. New players tend to put their first questions in LOOC, this makes it easier for mentors to catch wind of questions in LOOC and point them in the right direction. Also I want more opportunities to initiate tickets with new players.

LOOC also outputs in runechat!

Makes LOOC easier for everyone else to notice without looking in chat. Even if a Mentor/Admin doesn't notice what you're saying, another player might. Also might encourage LOOC usage in place of saying "this stupid fucking PR" in character.

People (including me) keep confusing mentor OOC with common radio because it's too bright.

Also Lumi kept yelling at me to make msay properly tagged.

Changelog

🆑
admin: Mentor ghosts may now see LOOC from anywhere.
admin: Staff may turn off LOOC spying in preferences.
qol: LOOC now outputs in runechat.
qol: Mentor OOC is slightly darker.
qol: Msay is now tagged with "MENTOR:" to reduce confusion for admins.
soundadd: Admin tickets turned into mentor tickets will not play the admin bwoink sound, instead using the mentor bwoink sound.
fix: Mentor PMs will not be super small anymore.
/:cl:

…taff LOOC, tooltips in GameSettings.tsx, new looc color, mentor PMs look how they should, msay says that it's msay to avoid confusion
Copy link
Contributor

@Barnet2 Barnet2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine on headmin/headmentor side of things

@TiviPlus TiviPlus added the Administration Alters the administrative tools used in-game. label Jan 22, 2025
@TiviPlus
Copy link
Member

we do not have a tweak: tag anymore fix your cl

@Neocloudy
Copy link
Contributor Author

Neocloudy commented Jan 22, 2025

we do not have a tweak: tag anymore fix your cl

it seemed to exist when i checked changelog react-side code wtf... idk what to replace it with

@TiviPlus TiviPlus added Sound Sound change. Fix Fixes an issue with the game. Quality of Life Minor changes that make the game nicer to play labels Jan 24, 2025
@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jan 27, 2025
@yyzsong
Copy link
Contributor

yyzsong commented Jan 30, 2025

Let mentors mooc and xooc at any time pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration Alters the administrative tools used in-game. Fix Fixes an issue with the game. Quality of Life Minor changes that make the game nicer to play Sound Sound change. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants