Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Globadier, a new spitter strain #16953

Merged
merged 39 commits into from
Feb 12, 2025
Merged

Conversation

Mantlecrawler
Copy link
Contributor

@Mantlecrawler Mantlecrawler commented Jan 20, 2025

About The Pull Request

Adds the globadier, a new spitter strain. It focuses on aoe attacks, trading its spit and spray for the ability to lay acid and gas mines, and to fling various types of grenades.
Full Design Doc Here : https://hackmd.io/@11BangBang/H1ELFixwJg

Images (NOTE: OUTDATED)

(Acid & Resin Grenades)
dreamseeker_h6aHea7nH2
(Sprite)
dreamseeker_UPFG7OuDqg
(Acid Rocket. Sprites have been changed since this was taken.
dreamseeker_Swmhpo6Gtm

It gains 4 abilities, and a primo

Toss Grenade
Toss a grenade at your target, with a limited range. Select grenade type via rclick, of which there are currently 5 :
Resin, which spreads sticky resin and flings those nearby, along with allowing the globadier to rocket jump
Acid, which spreads acid, light acid gas, and deals acid damage to those nearby
Incendiary, which spreads long lasting pryogen fire
Gas, which spreads thin neuro smoke in a large AOE.
Healing, which heals nearby xenos a small amount when it detonates. Longer fuse than other nades
Stores 6, with one regenerating every 20 seconds. 150 Plasma to throw, 2s cooldown between throws, 1.5 second fuse on the grenades (for acid grenades, the fuse is 1 second, heal nades have a 4s fuse)

Place Acid/Gas Mine (Two Abilities)
Place a acid or gas mine, which detonate when destroyed or stepped on by a human. Deals AOE damage, and gas mines spread extra damage. Stores 6/3, regenerating one every 40/80 seconds, with a 5 second cooldown between places. Must be on weeds

Acid Rocket (Primordial)
Launch a acid rocket, similar to sadar. After a .8s warmup, takes 30% of your health and plasma, and fires a projectile which deals 90 damage with 10 AP to everything nearby, spreading acid spatter that lasts for 5 seconds, and deals an additional 30 damage to the direct hit target. Has 1.3x damage on vehicles

It looses 2 slash damage, for a total of 18, from 20.
It looses 40 health, for a total of 320, from 360.
Other stats remain unchanged.

Why It's Good For The Game

Discord_LG1tBwJ99a

Changelog

🆑 Cheese (Code), Kuro (sprites), Mack (Ideasguy)
add: Added Globadier, a new spitter strain.
/:cl:

@TiviPlus TiviPlus added Sprites Changes to .dmi file. Feature New interesting mechanics with new interesting bugs labels Jan 20, 2025
@TiviPlus TiviPlus self-assigned this Jan 20, 2025
@Pariah919
Copy link
Contributor

Pariah919 commented Jan 21, 2025

Yeahhhh Conceptually not sold on this. Seems like it'll sit in bull tier of being absurdly broken or just bad. At least Sizzler seems like an okay concept. This just seems wack.

0,0,0,4 explosive

Also why would you add an explosion at all? They aren't really balanced to be on benos period. Just make it spread out shrapnel in a 360 area.

@Lumipharon
Copy link
Contributor

Giving it weeding just cuz is pretty stinky tbh

@Mantlecrawler
Copy link
Contributor Author

Giving it weeding just cuz is pretty stinky tbh

Its traps can only be placed on weeds.

@Lumipharon
Copy link
Contributor

lucky its a team game then, and you can rely on weeding castes

Copy link
Member

@TiviPlus TiviPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like a lot of the vars you had were supposed to be magic number defines

@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jan 26, 2025
@novaepee
Copy link
Contributor

xadar is op

@CaputCapital
Copy link

xadar is op

xadarr.mp4

brutal

@CaputCapital
Copy link

xadarr2.mp4

Mimir modules both mark 1 and 2 will not protect against xadars.

@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label Jan 27, 2025
@github-actions github-actions bot removed the Merge Conflict Pull request is in a conflicted state with base branch. label Jan 28, 2025
@Liznerd
Copy link

Liznerd commented Jan 29, 2025

Yeah this seems... a bit more on the busted side...? the grenades are cool and I love them and add a lot of interaction, marines can even pick them up and throw em back, but the rocket is just not a good idea, is WAY too strong and the plasma and health cost doesn't set it back one bit, because is a range attack that travels insanely fast and delivers a lot.

@Mannybrado
Copy link
Contributor

rather predictably, the detonation timer being reset upon picking up one of the grenades has made the caste exceptionally terrible, as marines are able to pick up the grenades and throw them back very consistently. you should either get rid of this or reduce the explosion timer to its harder to do this.

deltimer(det_timer)
det_timer = addtimer(CALLBACK(src, PROC_REF(prime)), det_time, TIMER_STOPPABLE)
det_timer = addtimer(CALLBACK(src, PROC_REF(prime)), (curtime + GLOBADIER_GRENADE_PICKUP_CD), TIMER_STOPPABLE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems highly exploitable since you can just increase the det time infinitely. Why are you changing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ill change it to have a max value

@@ -434,9 +434,11 @@
if(istype(target_obj,/obj/hitbox))
var/obj/hitbox/vehiclehitbox = target_obj
vehiclehitbox.root.take_damage(90 * XADAR_VEHICLE_DAMAGE_MULT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does the mult even exist? you're multiplying a random number which isnt used anywhere else, just set the actual number you want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mack wanted it as a multiplier but yeah i can just change it to whatever.

@Pariah919
Copy link
Contributor

i just realized, these are grenades. they go over cades. WHY

@Mannybrado
Copy link
Contributor

Mannybrado commented Feb 9, 2025

come to remind that the grenade fuse resetting on being picked up is still terrible

a t2 being hard countered by 1 marine with no special equipment is bad actually

@github-actions github-actions bot removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Feb 10, 2025
@TiviPlus TiviPlus merged commit 086bb46 into tgstation:master Feb 12, 2025
42 checks passed
github-actions bot added a commit that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Sprites Changes to .dmi file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants