Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial transpose table (#22) #30

Closed
wants to merge 1 commit into from
Closed

Conversation

mochsner
Copy link

@tgrosinger it's definitely not the prettiest code (due to the need to ignore the delimiter row on both read and write being quite confusing, but I've been a bit strapped for time recently and haven't been able to dive into this code gain. It works well, so let me know what you think.

The main thing that would really help readability for this is if we could (before any computation) just remove the delimiter row flat out. If you have a decent idea of an approach to do that, I'd love to know how. Alternatively, if you wanted to make any changes in my PR, I've granted you full permissions :)

@mochsner
Copy link
Author

Note: happy to help with the obsidian plugin development for this as well. I assume we'll need an icon, which would really be the hardest part imo. I tested this through your advanced-tables obsidian plugin, so let me know if you'd like some help with that too.

Copy link
Author

@mochsner mochsner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgrosinger What additional test cases you'd want to see handled here (e.g. particular chars in header divider, no spacing in cells, etc.)? I wasn't exhaustive for this case to avoid bloat, but happy to add more in. The code is fully working afaik.

@ooker777
Copy link

ooker777 commented Sep 2, 2024

@tgrosinger as I see that you are still active in this plugin, would you consider to take a look at this PR?
@mochsner do you still use Obsidian with the latest version and your plugin? Your repo has not received any new commit for 3 years. I'm not sure if it still works

@tgrosinger
Copy link
Owner

Merged! Thank you.

@tgrosinger tgrosinger closed this Sep 5, 2024
@mochsner
Copy link
Author

mochsner commented Sep 7, 2024

@ooker777 I do still actively use, but not with my changes side-loaded, as my use case for it has gone done outside of previously company I was working at. Glad to know it sounds like it still works :smile . Hope you guys are able to get a UI option into the actual tables plugin some point soon too!

@mochsner
Copy link
Author

mochsner commented Sep 7, 2024

P.S. just saw the change, and congrats on the new role @tgrosinger - well deserved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants