-
Notifications
You must be signed in to change notification settings - Fork 4
GitHub Actions #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
GitHub Actions #37
Changes from all commits
735d5d3
527157b
d042010
bdd0ccc
853f677
3666bed
6e0a607
7e47946
119fbac
ef384cb
2a75b8b
7652726
7987029
e774f0a
b1eb6ea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: actions | ||
|
||
on: [push] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
|
||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
|
||
- name: Check diff | ||
uses: docker://tfug/proofreading:latest | ||
with: | ||
args: ./bin/run tensorflow/docs-l10n master 10 | ||
|
||
- name: Check all | ||
uses: docker://tfug/proofreading:latest | ||
with: | ||
args: ./bin/run tensorflow/docs-l10n master all 10 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
# Temporary directory to clone GitHub repository | ||
ghrepos | ||
# Default log file | ||
result.txt | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
# Proofreading for TensorFlow docs translation | ||
|
||
 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. このCIジョブはすべてのブランチでのpushイベントに対して発火するように設定されていますが、その結果をバッチに出すとmasterはちゃんと動作しているのにfailが表示されてしまうということになり、メンテナンスされていないかのように受け取られます。 このリポジトリ上でGithub Actionsを使って実現できそうなことは以下の3つがあります。(他にもブランチの定期削除とかもできますが)
このPRでの内容は上記の There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. たぶん今の状態だとバッジ上のステータスはブランチに関わらずデフォルトブランチである master のステータスが表示されるので、懸念しているような master 以外のブランチで CI 失敗して failed が表示されるということにはならないかと。 |
||
|
||
## Description | ||
|
||
[tensorflow/docs](https://github.com/tensorflow/docs)の日本語訳の表記ゆれ等をチェックするツールです。 | ||
|
@@ -47,6 +49,8 @@ $ ./bin/run-docker tensorflow/docs master | |
$ ./bin/run-docker tensorflow/docs master all | ||
``` | ||
|
||
It uses Docker image [tfug/proofreading](https://hub.docker.com/r/tfug/proofreading). | ||
|
||
## Why use RedPen? | ||
|
||
We are working on translation with more than one person. So It is expected that a lot of orthographical variants will occur. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
#!/bin/bash | ||
|
||
docker run \ | ||
-it \ | ||
--rm \ | ||
-v $(PWD):/usr/local/documents \ | ||
-v $(pwd):/usr/local/documents \ | ||
tfug/proofreading \ | ||
/bin/ash ./bin/run ${1} ${2} ${3} | ||
/bin/ash ./bin/run $@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bin/run
では結果のファイルはresult.txt
でなくても第3引数で指定できるようになっています。#33 (comment) でコメントしましたが、
result.txt
に固定して引数で渡さないようにするのがいいかなと思っています。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここは #42 で修正済み
master 側で大きい修正が入ったので、いったん master をこっちの branch にマージして、ついでに conflict の解消とかしました