Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added new rule, return type for functions is now explicit #15

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kbsaid
Copy link

@kbsaid kbsaid commented Oct 19, 2022

No description provided.

@kbsaid kbsaid changed the title fix: added new rule, return type for functions is now explcit fix: added new rule, return type for functions is now explicit Oct 19, 2022
@kbsaid
Copy link
Author

kbsaid commented Nov 4, 2022

@Simon-HL @edgarbjorntvedt @lostfields @Luzenna
I henhold til samtalen vi hadde under kompetansehevingsdag rundt endring av eslint for backend. Hvor vi eksplisitt setter return types i våre funksjoner. Foreløpig er denne regelen off i vår pakke. Men tenker det kan være lurt å implementere det slik at vi forholder oss til vår handbook og kodestandard.

Det ble tatt fram noen gode spørsmål om hvordan vi skal håndtere disse feilmeldinger om det skal være en warning eller en error. Tenker vi burde diskutere rundt dette her. Og komme til en enighet hvor vidt dette skal implementeres.

Legger til et dokument jeg skrev under kompetansehevingsdagen med litt kode eksempler på hvordan vi burde gjøre det.:
https://24so.atlassian.net/wiki/spaces/PD/pages/1443266590/2022-10-19+-+Making+new+ESLint+rule+for+TS+projects

@lostfields
Copy link
Collaborator

Det blir mange breaking repos det ute med denne endringen. Hva om vi legger opp til en nytt regelsett for typescript-strict i tillegg til dagens typescript?

@Luzenna Luzenna removed their request for review January 6, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants