Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conv1d #76

Merged
merged 9 commits into from
Nov 25, 2023
Merged

Conv1d #76

merged 9 commits into from
Nov 25, 2023

Conversation

tfjgeorge
Copy link
Owner

No description provided.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5658a74) 94.89% compared to head (bce2cc6) 95.44%.

❗ Current head bce2cc6 differs from pull request most recent head 418beb9. Consider uploading reports for the commit 418beb9 to get more accurate results

Files Patch % Lines
nngeometry/generator/jacobian/jacobian.py 80.00% 2 Missing ⚠️
nngeometry/generator/jacobian/grads_conv.py 93.33% 1 Missing ⚠️
nngeometry/layercollection.py 94.11% 1 Missing ⚠️
tests/tasks.py 96.66% 1 Missing ⚠️
tests/test_jacobian.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   94.89%   95.44%   +0.55%     
==========================================
  Files          31       31              
  Lines        3464     3580     +116     
==========================================
+ Hits         3287     3417     +130     
+ Misses        177      163      -14     
Flag Coverage Δ
unittests 95.44% <96.17%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfjgeorge tfjgeorge changed the title wip Conv1d Nov 24, 2023
@tfjgeorge tfjgeorge marked this pull request as ready for review November 25, 2023 12:36
@tfjgeorge tfjgeorge merged commit 7e0e88f into master Nov 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant