Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pattern matches #2658

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Fix pattern matches #2658

merged 1 commit into from
Feb 15, 2025

Conversation

dcooper16
Copy link
Contributor

Describe your changes

This PR fixes three lines of code that use Bash substring matching. In each case, a list of strings to match was enclosed in brackets. This resulted in a match if the string to test contained any character from any of the strings to match. This PR fixes the issue by removing the brackets. (This PR also fixes a typo that was already fixed in the 3.2 branch.)

I have tested the change in run_npn(), but have not tested the changes in the other two functions.

(The bugs were introduced in b8e9b09 and 8149c2d)

What is your pull request about?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs and the indentation is five spaces
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

This commit fixes three lines of code that use Bash substring matching. In each case, a list of strings to match was enclosed in brackets. This resulted in a match if the string to test contained any character from any of the strings to match. This commit fixes the issue by removing the brackets.

(The bugs were introduced in testssl@b8e9b09 and testssl@8149c2d)
@drwetter drwetter merged commit 94b590f into testssl:3.0 Feb 15, 2025
2 checks passed
@drwetter
Copy link
Collaborator

Thanks again!

@dcooper16 dcooper16 deleted the fix_pattern_match_30 branch February 18, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants