Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: continue tests where possible #2814

Closed
wants to merge 1 commit into from
Closed

Conversation

JoelLau
Copy link
Contributor

@JoelLau JoelLau commented Oct 5, 2024

What does this PR do?

  • replaced assert with require where possible

Why is it important?

  • increase the amount of information in each test by continuing execution
    • NOTE: i've only made changes where i think assertions can be made in parallel (in theory), where failing an assertion will not lead to an error state in subsequent tests

Related issues

@JoelLau JoelLau requested a review from a team as a code owner October 5, 2024 02:00
Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 22816d6
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67009dbf501a57000814d1ef
😎 Deploy Preview https://deploy-preview-2814--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not a fan of this approach as it just tends to result in a lot of noise which creates little to no value, better to just fail on the first error.

@mdelapenya
Copy link
Member

mdelapenya commented Oct 7, 2024

Exactly, the intent is just the opposite, and use require over assert if/when possible. @JoelLau could you update the PR with that? 🙏

@stevenh
Copy link
Contributor

stevenh commented Oct 7, 2024

Given this is only replacing require with assert which is moving in the wrong way, I'm going to close this as it will be easier to create a new one moving in the right direction.

@stevenh stevenh closed this Oct 7, 2024
@JoelLau
Copy link
Contributor Author

JoelLau commented Oct 7, 2024

my bad, idk how i got it the wrong way around. thanks for looking at this and sorry for the noise

@stevenh
Copy link
Contributor

stevenh commented Oct 7, 2024

Thank you for the effort @JoelLau, its great to have community engagement, that's what open source is all about 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants