-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Async Support #462
base: main
Are you sure you want to change the base?
WIP: Async Support #462
Conversation
*looking at the merge conflicts - A rebase on the current |
@tessi how are we doing with this PR? What is remaining for us to get this to finish line? Is there anything I can help with? |
hey @munjalpatel :) thanks for asking and reminding me. I'm afraid this PR got stuck half way (I got a baby in between - it's been a while - and turns out these babies eat your free time as if it is milk!). Now, wasmtime has seen a fair amount of churn over the versions and the way async is handled changed enough so that I'd probably restart the work on a fresh wasmtime version update. Good news is, that I'm working on a wasmtime version update just because of that behind the scenes. I probably have a WIP PR ready for that version bump soon - if the baby let's me sleep enogh, that is :) |
@tessi congratulations on the baby!! Happy to help wherever I can :) |
Hey @munjalpatel and @scrogson (maybe, hopefully! :D) I just pushed a WIP version of a new async attempt. the full error is listed below, but I also have a short video explaining what I think is the problem: I don't know a solution to this error as I understand it, but without solving it I'm afraid we cannot use async wasmtime :/ The error:
(please not that this is WIP and probably all tests fail, but I only care about fixing this error at the moment, the rest will follow) |
@tessi I'll try to pull in the code locally tonight and see if I can figure something out. |
This is a work-in-progress to implement an async rust backend for wasmex. Have a look at the
async_todo.md
(and keep it up-to-date).See: #394
When working on this, make sure to
export WASMEX_BUILD=true
(this let's you build the rust binary locally instead of downloading a prebuilt binary).