Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeScript signatures #2441

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Fix TypeScript signatures #2441

merged 1 commit into from
Mar 22, 2025

Conversation

stereobooster
Copy link
Contributor

I missed small things in the first PR. Some follow up fixes

alixander
alixander approved these changes Mar 22, 2025
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with typescript ecosystem, deferring to you, ty!

@stereobooster
Copy link
Contributor Author

I tested locally, by editing files directly in node_modules. It worked at least in my case.

@alixander alixander merged commit 98aea4c into terrastruct:master Mar 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stereobooster @alixander