Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing commit msg checkbox from PR template #2078

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Removing commit msg checkbox from PR template #2078

merged 2 commits into from
Feb 10, 2025

Conversation

john-science
Copy link
Member

What is the change?

Removed one checkbox from the PR template:

Why is the change being made?

We have a squash-and-merge policy for ARMI PRs. So I don't care if you have some silly PR messages in the history of your feature branch.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Feb 7, 2025
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you to rephrase the sentence I commented on to your liking. Approved!

.github/pull_request_template.md Outdated Show resolved Hide resolved
@john-science john-science merged commit dd8effe into main Feb 10, 2025
22 checks passed
@john-science john-science deleted the pr_form branch February 10, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants