-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting the armi.testing modules #2028
Conversation
Again, @opotowsky, I'm sorry this touches so many files. BUT, the only two non-trivial files changes are The rest is just me making use of the new location. But the change is still backward compatible for projects outside ARMI, because Sorry for the PR onslaught! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged the ruff PR so you have a number of merge conflicts here. But feel free to merge this once those are handled!
What is the change?
Here I am starting the
armi.testing
module.Basically, I just move
loadTestReactor()
fromarmi.reactor.test.test_reactor
toarmi.testing
.Why is the change being made?
Right now, every single ARMI unit test is importable as part of the API. But that can't last forever. ARMI 1.0.0 will have a more usual API, without less importable noise.
A better paradigm to follow would be
numpy
. The NumPy team does not let you import their unit tests, that's madness.Instead, they provide
import numpy.testing
, which houses a small set of high-quality testing utilities for people to use when testing NumPy-based code. So, we will follow NumPy's example.progress on #1867
Checklist
doc
folder.pyproject.toml
.