Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving from shutil.copy to safeCopy #2024

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Moving from shutil.copy to safeCopy #2024

merged 3 commits into from
Nov 26, 2024

Conversation

john-science
Copy link
Member

What is the change?

Moving from shutil.copy to safeCopy.

Why is the change being made?

This is meant to start the work on #1690

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Nov 26, 2024
opotowsky
opotowsky approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃🎉

@opotowsky opotowsky merged commit 8b9a693 into main Nov 26, 2024
22 checks passed
@opotowsky opotowsky deleted the rm_safecopy_hack branch November 26, 2024 23:50
drewj-tp added a commit that referenced this pull request Nov 27, 2024
@drewj-tp
Merge remote-tracking branch 'origin/main' into drewj/bu-rotate-with-…
12f51aa 
…pin-dep

* origin/main:
  Moving from shutil.copy to safeCopy (#2024)
  Move files from temporary directory changer (#2022)
  Handling checking for OSs better (#2023)
  Expose some skip inspection options for `armi.init` and `db.loadOperator` (#2005)
  Adding setting to control MCNP / ENDF library (#1989)
  Improving logging on ISOTXS compare  (#2013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-science @opotowsky