Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
I went through all instance of
sys.platform
in ARMI to check that we were handling it correcty.Why is the change being made?
The problem I found was people were doing this to test if the current OS is Windows:
This is because
sys.platform
returns"win32"
for Windows, but it also returns"darwin"
for MacOS.Here is a helpful table:
Checklist
doc
folder.pyproject.toml
.