Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing send for create all metrics #1992

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

snakster
Copy link
Contributor

@snakster snakster commented Dec 2, 2024

What this PR does / why we need it:

This fixes a missing send in one code path.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

no

Copy link

github-actions bot commented Dec 2, 2024

2024/12/02 14:43:48 Terraform detected version: 1.9.8
toolsetPath: /tmp/cmd-terramate-test-2134246651
=== RUN   TestInteropCloudSyncPreview
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
--- PASS: TestInteropCloudSyncPreview (13.50s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift (6.96s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id (6.54s)
=== RUN   TestInteropSyncDeployment
=== RUN   TestInteropSyncDeployment/deployment:_empty
=== RUN   TestInteropSyncDeployment/deployment:_empty-uppercase-id
--- PASS: TestInteropSyncDeployment (45.53s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty (22.83s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty-uppercase-id (22.69s)
=== RUN   TestInteropDrift
=== RUN   TestInteropDrift/drift:_basic-drift
=== RUN   TestInteropDrift/drift:_basic-drift-uppercase-id
--- PASS: TestInteropDrift (74.17s)
    --- PASS: TestInteropDrift/drift:_basic-drift (37.24s)
    --- PASS: TestInteropDrift/drift:_basic-drift-uppercase-id (36.93s)
PASS
ok  	github.com/terramate-io/terramate/e2etests/cloud/interop	195.777s

Copy link

github-actions bot commented Dec 2, 2024

Preview of ubuntu-focal/go1.21 tests in 7eb9b4a

🔍 View Details on Terramate Cloud

cmd/terramate/cli

Copy link

github-actions bot commented Dec 2, 2024

Preview of macos-ventura/go1.21 tests in 7eb9b4a

🔍 View Details on Terramate Cloud

cmd/terramate/cli

Copy link

github-actions bot commented Dec 2, 2024

metric: time/op
ChangeDetection-4: old 4.12ms ± 4%: new 4.11ms ± 4%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 13.9ms ± 3%: new 14.0ms ± 1%: delta: 0.00%
CloudReadLines-4: old 1.10ms ± 5%: new 1.06ms ± 3%: delta: -3.29%
CloudReadLine-4: old 7.51ms ± 1%: new 7.47ms ± 1%: delta: -0.49%
ListFiles-4: old 88.4µs ± 1%: new 88.3µs ± 1%: delta: 0.00%
Generate-4: old 1.61s ± 3%: new 1.62s ± 3%: delta: 0.00%
GenerateRegex-4: old 1.11s ± 4%: new 1.12s ± 3%: delta: 1.34%
TokensForExpressionComplex-4: old 1.27ms ± 1%: new 1.27ms ± 1%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 800ns ± 1%: new 801ns ± 1%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 24.3µs ± 2%: new 24.1µs ± 1%: delta: -0.89%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.46ms ± 0%: new 1.46ms ± 0%: delta: 0.00%
TokensForExpression-4: old 1.27ms ± 0%: new 1.27ms ± 1%: delta: 0.00%
PartialEvalComplex-4: old 563µs ± 2%: new 559µs ± 1%: delta: 0.00%
PartialEvalSmallString-4: old 3.96µs ± 1%: new 3.98µs ± 1%: delta: 0.28%
PartialEvalHugeString-4: old 1.92ms ± 1%: new 1.92ms ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 5.18ms ± 4%: new 5.13ms ± 2%: delta: -0.94%
PartialEvalObject-4: old 27.7µs ± 3%: new 27.9µs ± 1%: delta: 0.56%
TmAllTrueLiteralList-4: old 629µs ± 1%: new 632µs ± 2%: delta: 0.00%
TmAllTrueFuncall-4: old 20.9µs ± 1%: new 20.9µs ± 1%: delta: 0.00%
TmAnyTrueLiteralList-4: old 4.93ms ± 1%: new 4.94ms ± 1%: delta: 0.00%
TmAnyTrueFuncall-4: old 21.2µs ± 1%: new 21.2µs ± 1%: delta: 0.00%
TmTernary-4: old 2.57µs ± 1%: new 2.56µs ± 1%: delta: -0.31%
TmTryUnknownFunc-4: old 2.32µs ± 1%: new 2.31µs ± 1%: delta: -0.37%
TmTryUnknownVariable-4: old 2.22µs ± 1%: new 2.22µs ± 1%: delta: 0.00%
TmTryUnknownObjectKey-4: old 2.56µs ± 1%: new 2.55µs ± 1%: delta: -0.47%
metric: alloc/op
ChangeDetection-4: old 356kB ± 0%: new 356kB ± 0%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 4.81MB ± 0%: new 4.81MB ± 0%: delta: 0.00%
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: -0.00%
ListFiles-4: old 27.6kB ± 0%: new 27.6kB ± 0%: delta: 0.00%
Generate-4: old 2.24GB ± 0%: new 2.24GB ± 0%: delta: 0.00%
GenerateRegex-4: old 926MB ± 0%: new 927MB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 395kB ± 0%: new 395kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.5kB ± 0%: new 12.5kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 395kB ± 0%: new 395kB ± 0%: delta: 0.00%
TokensForExpression-4: old 395kB ± 0%: new 395kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 361kB ± 0%: new 361kB ± 0%: delta: -0.00%
PartialEvalSmallString-4: old 1.95kB ± 0%: new 1.95kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 196kB ± 0%: new 196kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.31MB ± 0%: new 4.31MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 19.4kB ± 0%: new 19.4kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 321kB ± 0%: new 321kB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 10.6kB ± 0%: new 10.6kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 2.09MB ± 0%: new 2.09MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 10.7kB ± 0%: new 10.7kB ± 0%: delta: 0.00%
TmTernary-4: old 1.18kB ± 0%: new 1.18kB ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 784B ± 0%: new 784B ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 768B ± 0%: new 768B ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 952B ± 0%: new 952B ± 0%: delta: 0.00%
metric: allocs/op
ChangeDetection-4: old 2.45k ± 0%: new 2.45k ± 0%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 33.8k ± 0%: new 33.8k ± 0%: delta: 0.00%
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 335 ± 0%: new 335 ± 0%: delta: 0.00%
Generate-4: old 25.7M ± 0%: new 25.7M ± 0%: delta: 0.00%
GenerateRegex-4: old 18.4M ± 0%: new 18.4M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 3.78k ± 0%: new 3.78k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 26.0 ± 0%: new 26.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 38.0 ± 0%: new 38.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 26.1k ± 0%: new 26.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 183 ± 0%: new 183 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 5.94k ± 0%: new 5.94k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 275 ± 0%: new 275 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 59.6k ± 0%: new 59.6k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 277 ± 0%: new 277 ± 0%: delta: 0.00%
TmTernary-4: old 27.0 ± 0%: new 27.0 ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%

@snakster snakster marked this pull request as ready for review December 2, 2024 14:40
@snakster snakster requested a review from a team as a code owner December 2, 2024 14:40
@snakster snakster force-pushed the snk-fix-create-all-metrics branch from af2eca9 to 7eb9b4a Compare December 2, 2024 14:41
Copy link
Contributor

@i4ki i4ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snakster snakster merged commit a2fdb72 into main Dec 2, 2024
7 checks passed
@snakster snakster deleted the snk-fix-create-all-metrics branch December 2, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants