Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add terramate create --all-terragrunt --tags a,b,c #1985

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: add terramate create --all-terragrunt --tags a,b,c #1985

merged 1 commit into from
Dec 2, 2024

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Nov 28, 2024

What this PR does / why we need it:

Add terramate create --all-terragrunt --tags a,b,c.

Which issue(s) this PR fixes:

Fixes #1966

Special notes for your reviewer:

Does this PR introduce a user-facing change?

yes, add --tags to `create --all-terragrunt`.

@i4ki i4ki requested a review from a team as a code owner November 28, 2024 22:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading 

2024/11/29 22:43:51 Terraform detected version: 1.9.8
toolsetPath: /tmp/cmd-terramate-test-930880915
=== RUN   TestInteropCloudSyncPreview
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
--- PASS: TestInteropCloudSyncPreview (11.71s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift (5.84s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id (5.87s)
=== RUN   TestInteropSyncDeployment
=== RUN   TestInteropSyncDeployment/deployment:_empty
=== RUN   TestInteropSyncDeployment/deployment:_empty-uppercase-id
--- PASS: TestInteropSyncDeployment (35.79s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty (17.93s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty-uppercase-id (17.87s)
=== RUN   TestInteropDrift
=== RUN   TestInteropDrift/drift:_basic-drift
=== RUN   TestInteropDrift/drift:_basic-drift-uppercase-id
--- PASS: TestInteropDrift (59.39s)
    --- PASS: TestInteropDrift/drift:_basic-drift (29.87s)
    --- PASS: TestInteropDrift/drift:_basic-drift-uppercase-id (29.52s)
PASS
ok  	github.com/terramate-io/terramate/e2etests/cloud/interop	163.294s

@i4ki i4ki force-pushed the i4k-add-tags-to-terragrunt-creation branch 2 times, most recently from 5d181c4 to e51204d Compare November 28, 2024 22:52
@i4ki i4ki changed the title feat: add terramate create --all-terragrunt --tags a,b,c fix: add terramate create --all-terragrunt --tags a,b,c Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Preview of ubuntu-focal/go1.21 tests in cba297a

🔍 View Details on Terramate Cloud

.
cmd/terramate/cli
e2etests/core

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading 

metric: time/op
ChangeDetection-4: old 3.99ms ± 6%: new 4.02ms ± 5%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 13.0ms ± 3%: new 13.0ms ± 2%: delta: 0.00%
CloudReadLines-4: old 991µs ±10%: new 1025µs ± 5%: delta: 3.47%
CloudReadLine-4: old 7.41ms ± 1%: new 7.41ms ± 1%: delta: 0.00%
ListFiles-4: old 86.7µs ± 1%: new 87.0µs ± 1%: delta: 0.00%
Generate-4: old 1.56s ± 3%: new 1.55s ± 3%: delta: 0.00%
GenerateRegex-4: old 1.06s ± 3%: new 1.06s ± 5%: delta: 0.00%
TokensForExpressionComplex-4: old 1.25ms ± 0%: new 1.25ms ± 1%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 793ns ± 1%: new 789ns ± 1%: delta: -0.61%
TokensForExpressionStringWith100Newlines-4: old 23.9µs ± 2%: new 23.9µs ± 3%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.45ms ± 0%: new 1.45ms ± 0%: delta: -0.18%
TokensForExpression-4: old 1.26ms ± 1%: new 1.26ms ± 0%: delta: 0.00%
PartialEvalComplex-4: old 540µs ± 1%: new 540µs ± 1%: delta: 0.00%
PartialEvalSmallString-4: old 3.89µs ± 0%: new 4.04µs ± 3%: delta: 3.85%
PartialEvalHugeString-4: old 1.91ms ± 0%: new 1.91ms ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.92ms ± 1%: new 4.92ms ± 1%: delta: 0.00%
PartialEvalObject-4: old 26.4µs ± 1%: new 26.5µs ± 1%: delta: 0.23%
TmAllTrueLiteralList-4: old 615µs ± 1%: new 616µs ± 1%: delta: 0.00%
TmAllTrueFuncall-4: old 20.2µs ± 1%: new 20.2µs ± 1%: delta: 0.00%
TmAnyTrueLiteralList-4: old 4.85ms ± 1%: new 4.87ms ± 0%: delta: 0.41%
TmAnyTrueFuncall-4: old 20.7µs ± 1%: new 20.8µs ± 1%: delta: 0.28%
TmTernary-4: old 2.52µs ± 1%: new 2.50µs ± 0%: delta: -0.94%
TmTryUnknownFunc-4: old 2.29µs ± 1%: new 2.26µs ± 1%: delta: -1.16%
TmTryUnknownVariable-4: old 2.19µs ± 1%: new 2.16µs ± 1%: delta: -1.34%
TmTryUnknownObjectKey-4: old 2.50µs ± 1%: new 2.47µs ± 1%: delta: -1.35%
metric: alloc/op
ChangeDetection-4: old 356kB ± 0%: new 356kB ± 0%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 4.81MB ± 0%: new 4.81MB ± 0%: delta: 0.00%
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 27.6kB ± 0%: new 27.6kB ± 0%: delta: -0.01%
Generate-4: old 2.24GB ± 0%: new 2.24GB ± 0%: delta: 0.00%
GenerateRegex-4: old 926MB ± 0%: new 927MB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.5kB ± 0%: new 12.5kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 395kB ± 0%: new 395kB ± 0%: delta: 0.00%
TokensForExpression-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 361kB ± 0%: new 361kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.95kB ± 0%: new 1.95kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 196kB ± 0%: new 196kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.31MB ± 0%: new 4.31MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 19.4kB ± 0%: new 19.4kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 321kB ± 0%: new 321kB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 10.6kB ± 0%: new 10.6kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 2.09MB ± 0%: new 2.09MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 10.7kB ± 0%: new 10.7kB ± 0%: delta: 0.00%
TmTernary-4: old 1.18kB ± 0%: new 1.18kB ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 784B ± 0%: new 784B ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 768B ± 0%: new 768B ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 952B ± 0%: new 952B ± 0%: delta: 0.00%
metric: allocs/op
ChangeDetection-4: old 2.45k ± 0%: new 2.45k ± 0%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 33.7k ± 0%: new 33.7k ± 0%: delta: 0.00%
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 335 ± 0%: new 335 ± 0%: delta: 0.00%
Generate-4: old 25.7M ± 0%: new 25.7M ± 0%: delta: 0.00%
GenerateRegex-4: old 18.4M ± 0%: new 18.4M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 3.78k ± 0%: new 3.78k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 26.0 ± 0%: new 26.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 38.0 ± 0%: new 38.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 26.1k ± 0%: new 26.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 183 ± 0%: new 183 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 5.94k ± 0%: new 5.94k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 275 ± 0%: new 275 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 59.6k ± 0%: new 59.6k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 277 ± 0%: new 277 ± 0%: delta: 0.00%
TmTernary-4: old 27.0 ± 0%: new 27.0 ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Preview of macos-ventura/go1.21 tests in cf98258

🔍 View Details on Terramate Cloud

.
cmd/terramate/cli
e2etests/core

snakster
snakster reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@snakster snakster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for missing changelog entry

soerenmartius
soerenmartius previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@i4ki i4ki force-pushed the i4k-add-tags-to-terragrunt-creation branch from e51204d to cf98258 Compare November 29, 2024 22:41
@i4ki i4ki force-pushed the i4k-add-tags-to-terragrunt-creation branch from cf98258 to cba297a Compare November 29, 2024 22:41
@i4ki i4ki merged commit 385a749 into main Dec 2, 2024
7 checks passed
@i4ki i4ki deleted the i4k-add-tags-to-terragrunt-creation branch December 2, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snakster snakster snakster approved these changes

@soerenmartius soerenmartius soerenmartius left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support --tags option for terramate create --all-terragrunt
3 participants
@i4ki @soerenmartius @snakster