Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn if Terragrunt dependency is outside project. #1983

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Nov 28, 2024

What this PR does / why we need it:

Fix panic in the case of a Terragrunt module references a dependency outside of the Terramate project.
This changed adds a warning for such cases because this is not supported in Terramate at the moment.

Which issue(s) this PR fixes:

Fixes #1979

Special notes for your reviewer:

Does this PR introduce a user-facing change?

yes, fixes a panic in the Terragrunt integration.

@i4ki i4ki requested a review from a team as a code owner November 28, 2024 20:10
Copy link

github-actions bot commented Nov 28, 2024

2024/11/29 14:16:51 Terraform detected version: 1.9.8
toolsetPath: /tmp/cmd-terramate-test-1751228573
=== RUN   TestInteropCloudSyncPreview
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
--- PASS: TestInteropCloudSyncPreview (11.52s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift (6.02s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id (5.51s)
=== RUN   TestInteropSyncDeployment
=== RUN   TestInteropSyncDeployment/deployment:_empty
=== RUN   TestInteropSyncDeployment/deployment:_empty-uppercase-id
--- PASS: TestInteropSyncDeployment (36.74s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty (18.88s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty-uppercase-id (17.86s)
=== RUN   TestInteropDrift
=== RUN   TestInteropDrift/drift:_basic-drift
=== RUN   TestInteropDrift/drift:_basic-drift-uppercase-id
--- PASS: TestInteropDrift (59.31s)
    --- PASS: TestInteropDrift/drift:_basic-drift (29.37s)
    --- PASS: TestInteropDrift/drift:_basic-drift-uppercase-id (29.95s)
PASS
ok  	github.com/terramate-io/terramate/e2etests/cloud/interop	167.555s

Copy link

github-actions bot commented Nov 28, 2024

Preview of ubuntu-focal/go1.21 tests in 472146b

🔍 View Details on Terramate Cloud

.
cmd/terramate/cli
project
tg
e2etests/core

Copy link

github-actions bot commented Nov 28, 2024

Preview of macos-ventura/go1.21 tests in 472146b

🔍 View Details on Terramate Cloud

.
cmd/terramate/cli
project
tg
e2etests/core

@i4ki i4ki force-pushed the i4k-fix-tg-panic branch 2 times, most recently from 7642867 to 6ceaa1e Compare November 28, 2024 20:25
Copy link

github-actions bot commented Nov 28, 2024

metric: time/op
ChangeDetection-4: old 4.00ms ± 4%: new 4.01ms ± 5%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 13.0ms ± 4%: new 13.0ms ± 4%: delta: 0.00%
CloudReadLines-4: old 1.00ms ± 3%: new 1.00ms ± 5%: delta: 0.00%
CloudReadLine-4: old 7.42ms ± 3%: new 7.36ms ± 1%: delta: -0.86%
ListFiles-4: old 86.6µs ± 1%: new 87.0µs ± 2%: delta: 0.00%
Generate-4: old 1.55s ± 3%: new 1.55s ± 3%: delta: 0.00%
GenerateRegex-4: old 1.05s ± 3%: new 1.07s ± 4%: delta: 2.04%
TokensForExpressionComplex-4: old 1.25ms ± 0%: new 1.26ms ± 1%: delta: 1.06%
TokensForExpressionPlainStringNoNewline-4: old 790ns ± 1%: new 876ns ± 1%: delta: 10.86%
TokensForExpressionStringWith100Newlines-4: old 23.8µs ± 1%: new 24.2µs ± 2%: delta: 1.81%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.45ms ± 0%: new 1.45ms ± 0%: delta: 0.00%
TokensForExpression-4: old 1.26ms ± 1%: new 1.27ms ± 1%: delta: 0.89%
PartialEvalComplex-4: old 540µs ± 1%: new 540µs ± 1%: delta: 0.00%
PartialEvalSmallString-4: old 3.89µs ± 1%: new 3.89µs ± 1%: delta: 0.00%
PartialEvalHugeString-4: old 1.91ms ± 1%: new 1.93ms ± 1%: delta: 1.14%
PartialEvalHugeInterpolatedString-4: old 4.89ms ± 1%: new 4.91ms ± 2%: delta: 0.00%
PartialEvalObject-4: old 26.5µs ± 1%: new 26.7µs ± 1%: delta: 0.78%
TmAllTrueLiteralList-4: old 617µs ± 0%: new 616µs ± 1%: delta: 0.00%
TmAllTrueFuncall-4: old 20.2µs ± 1%: new 20.4µs ± 1%: delta: 0.77%
TmAnyTrueLiteralList-4: old 4.84ms ± 0%: new 4.87ms ± 1%: delta: 0.52%
TmAnyTrueFuncall-4: old 20.6µs ± 1%: new 20.6µs ± 0%: delta: 0.00%
TmTernary-4: old 2.52µs ± 0%: new 2.52µs ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 2.29µs ± 2%: new 2.28µs ± 0%: delta: -0.41%
TmTryUnknownVariable-4: old 2.18µs ± 1%: new 2.18µs ± 1%: delta: 0.20%
TmTryUnknownObjectKey-4: old 2.50µs ± 1%: new 2.49µs ± 0%: delta: -0.50%
metric: alloc/op
ChangeDetection-4: old 353kB ± 0%: new 356kB ± 0%: delta: 0.69%
ChangeDetectionTFAndTG-4: old 4.80MB ± 0%: new 4.81MB ± 0%: delta: 0.07%
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: -0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 27.6kB ± 0%: new 27.6kB ± 0%: delta: 0.00%
Generate-4: old 2.24GB ± 0%: new 2.24GB ± 0%: delta: 0.00%
GenerateRegex-4: old 926MB ± 0%: new 926MB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.5kB ± 0%: new 12.5kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 395kB ± 0%: new 395kB ± 0%: delta: 0.00%
TokensForExpression-4: old 394kB ± 0%: new 395kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 361kB ± 0%: new 361kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.95kB ± 0%: new 1.95kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 196kB ± 0%: new 196kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.31MB ± 0%: new 4.31MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 19.4kB ± 0%: new 19.4kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 321kB ± 0%: new 321kB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 10.6kB ± 0%: new 10.6kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 2.09MB ± 0%: new 2.09MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 10.7kB ± 0%: new 10.7kB ± 0%: delta: 0.00%
TmTernary-4: old 1.18kB ± 0%: new 1.18kB ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 784B ± 0%: new 784B ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 768B ± 0%: new 768B ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 952B ± 0%: new 952B ± 0%: delta: 0.00%
metric: allocs/op
ChangeDetection-4: old 2.39k ± 0%: new 2.45k ± 0%: delta: 2.45%
ChangeDetectionTFAndTG-4: old 33.6k ± 0%: new 33.7k ± 0%: delta: 0.25%
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 335 ± 0%: new 335 ± 0%: delta: 0.00%
Generate-4: old 25.7M ± 0%: new 25.7M ± 0%: delta: 0.01%
GenerateRegex-4: old 18.4M ± 0%: new 18.4M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 3.78k ± 0%: new 3.78k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 26.0 ± 0%: new 26.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 38.0 ± 0%: new 38.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 26.1k ± 0%: new 26.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 183 ± 0%: new 183 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 5.94k ± 0%: new 5.94k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 275 ± 0%: new 275 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 59.6k ± 0%: new 59.6k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 277 ± 0%: new 277 ± 0%: delta: 0.00%
TmTernary-4: old 27.0 ± 0%: new 27.0 ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@i4ki i4ki requested a review from snakster November 29, 2024 14:26
@i4ki i4ki merged commit 5139635 into main Nov 29, 2024
7 checks passed
@i4ki i4ki deleted the i4k-fix-tg-panic branch November 29, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants