feat: add telemetry #1981
Merged
feat: add telemetry #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
snakster
force-pushed
the
snk-add-telemetry
branch
2 times, most recently
from
21ac914 to
f8f728a
Compare
|
snakster
force-pushed
the
snk-add-telemetry
branch
2 times, most recently
from
f8f85f1 to
e37f69d
Compare
snakster
force-pushed
the
snk-add-telemetry
branch
3 times, most recently
from
f21a1e1 to
ef2117c
Compare
Preview of ubuntu-focal/go1.21 tests in 1f69272🔍 View Details on Terramate Cloud .
cmd/terramate/cli
cmd/terramate/cli/cliconfig
cmd/terramate/cli/telemetry
generate
generate/genfile
generate/genhcl
hcl
|
Preview of macos-ventura/go1.21 tests in 1f69272🔍 View Details on Terramate Cloud .
cmd/terramate/cli
cmd/terramate/cli/cliconfig
cmd/terramate/cli/telemetry
generate
generate/genfile
generate/genhcl
hcl
|
i4ki
reviewed
Nov 28, 2024
i4ki
requested changes
Nov 28, 2024
sixstone-qq
reviewed
Nov 28, 2024
| // Copyright 2023 Terramate GmbH | ||
| // SPDX-License-Identifier: MPL-2.0 | ||
|
|
||
| //go:build localhostEndpoints |
There was a problem hiding this comment.
Why don't you use environment variables?
There was a problem hiding this comment.
I'm using the same approach as the checkpoint API here. It could be more convenient for debugging, but beyond that there is no reason to make the endpoint address configurable, so I'd just go with the existing scheme.
snakster
force-pushed
the
snk-add-telemetry
branch
4 times, most recently
from
a1dbd15 to
fca5a8d
Compare
snakster
force-pushed
the
snk-add-telemetry
branch
from
fca5a8d to
859a1d7
Compare
snakster
force-pushed
the
snk-add-telemetry
branch
from
859a1d7 to
1f69272
Compare
i4ki
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds telemetry to collect metrics about which commands are used most actively. We already have some general insights from the checkpoint API, but this gives more detailed data.
Documentation will be updated accordingly.
Special notes for your reviewer:
Does this PR introduce a user-facing change?