Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: prereleases should not match constraints for previous versions. #1721

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented May 20, 2024

What this PR does / why we need it:

Improve the match of prereleases so ~> 1 does not match 2-alpha.
Even though the order 1 < 2-alpha < 2 is satisfied, the 2-alpha could potentially introduce breaking changes and then put projects using pessimistic operator at risk.

Which issue(s) this PR fixes:

none

Special notes for your reviewer:

Does this PR introduce a user-facing change?

yes, it's a breaking change.

@i4ki i4ki force-pushed the i4k-version-check-2 branch from 4d99533 to 8154e8b Compare May 20, 2024 17:21
Copy link

github-actions bot commented May 20, 2024

metric: time/op
CloudReadLines-4: old 1.00ms ± 3%: new 0.99ms ± 5%: delta: -1.49%
CloudReadLine-4: old 7.04ms ± 1%: new 7.03ms ± 1%: delta: 0.00%
ListFiles-4: old 53.3µs ± 1%: new 53.0µs ± 1%: delta: -0.48%
Generate-4: old 2.52s ± 1%: new 2.53s ± 2%: delta: 0.00%
GenerateRegex-4: old 1.73s ± 0%: new 1.74s ± 1%: delta: 0.42%
TokensForExpressionComplex-4: old 1.25ms ± 0%: new 1.25ms ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 811ns ± 0%: new 812ns ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 21.7µs ± 1%: new 21.8µs ± 1%: delta: 0.31%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.44ms ± 0%: new 1.44ms ± 0%: delta: 0.00%
TokensForExpression-4: old 1.25ms ± 0%: new 1.25ms ± 0%: delta: 0.00%
PartialEvalComplex-4: old 580µs ± 2%: new 578µs ± 1%: delta: 0.00%
PartialEvalSmallString-4: old 3.62µs ± 0%: new 3.61µs ± 0%: delta: -0.17%
PartialEvalHugeString-4: old 1.88ms ± 0%: new 1.88ms ± 0%: delta: 0.23%
PartialEvalHugeInterpolatedString-4: old 4.94ms ± 1%: new 4.92ms ± 1%: delta: -0.30%
PartialEvalObject-4: old 24.3µs ± 0%: new 24.3µs ± 1%: delta: 0.00%
TmAllTrueLiteralList-4: old 6.27ms ± 0%: new 6.30ms ± 1%: delta: 0.44%
TmAllTrueFuncall-4: old 161µs ± 0%: new 161µs ± 0%: delta: 0.14%
TmAnyTrueLiteralList-4: old 147ms ± 0%: new 147ms ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 161µs ± 0%: new 161µs ± 0%: delta: 0.09%
TmTernary-4: old 2.81µs ± 1%: new 2.84µs ± 0%: delta: 1.03%
TmTry-4: old 52.3µs ± 0%: new 52.2µs ± 0%: delta: 0.00%
metric: alloc/op
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 22.0kB ± 0%: new 22.0kB ± 0%: delta: 0.00%
Generate-4: old 2.32GB ± 0%: new 2.32GB ± 0%: delta: 0.00%
GenerateRegex-4: old 955MB ± 0%: new 955MB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 404kB ± 0%: new 404kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.4kB ± 0%: new 12.4kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 394kB ± 0%: new 394kB ± 0%: delta: -0.00%
TokensForExpression-4: old 404kB ± 0%: new 404kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 408kB ± 0%: new 408kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 21.9kB ± 0%: new 21.9kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 1.74MB ± 0%: new 1.74MB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 45.5kB ± 0%: new 45.5kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 37.9MB ± 0%: new 37.9MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 45.6kB ± 0%: new 45.6kB ± 0%: delta: 0.00%
TmTernary-4: old 1.20kB ± 0%: new 1.20kB ± 0%: delta: 0.00%
TmTry-4: old 11.2kB ± 0%: new 11.2kB ± 0%: delta: 0.00%
metric: allocs/op
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 321 ± 0%: new 321 ± 0%: delta: 0.00%
Generate-4: old 25.9M ± 0%: new 25.9M ± 0%: delta: 0.00%
GenerateRegex-4: old 18.6M ± 0%: new 18.6M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.84k ± 0%: delta: 0.01%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.84k ± 0%: new 4.84k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 3.65k ± 0%: new 3.65k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 153 ± 0%: new 153 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 13.6k ± 0%: new 13.6k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 460 ± 0%: new 460 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 252k ± 0%: new 252k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 462 ± 0%: new 462 ± 0%: delta: 0.00%
TmTernary-4: old 28.0 ± 0%: new 28.0 ± 0%: delta: 0.00%
TmTry-4: old 147 ± 0%: new 147 ± 0%: delta: 0.00%

@i4ki i4ki force-pushed the i4k-version-check-2 branch from 8154e8b to 36eba48 Compare May 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant