Skip to content

feat(TPG>=5.39)!: Added build_service_account argument for google_cloudfunctions_function #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −1
Open

feat(TPG>=5.39)!: Added build_service_account argument for google_cloudfunctions_function #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ea58ed
Update main.tf
maaaaaarkova Jan 22, 2025
12c85fd
Added build_service_account
maaaaaarkova Jan 22, 2025
c9a0162
Update versions.tf
maaaaaarkova Jan 22, 2025
53aca1b
Merge branch 'main' into main
apeabody Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ resource "google_cloudfunctions_function" "main" {
region = var.region
service_account_email = var.service_account_email
build_environment_variables = var.build_environment_variables
build_service_account = var.build_service_account
docker_registry = var.docker_registry
docker_repository = var.docker_repository
kms_key_name = var.kms_key_name
Expand Down
6 changes: 6 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ variable "service_account_email" {
description = "The service account to run the function as."
}

variable "build_service_account" {
type = string
default = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As google_cloudfunctions_function. build_service_account is optional, let's use a default of null.

Suggested change
default = ""
default = null

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After making the change, please run make docker_generate_docs and include in your commit.

description = "The self-provided service account to use to build the function. The format of this field is projects/{project}/serviceAccounts/{serviceAccountEmail}"
}

variable "bucket_name" {
type = string
default = ""
Expand Down
2 changes: 1 addition & 1 deletion versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ terraform {

google = {
source = "hashicorp/google"
version = ">= 4.23, < 7"
version = ">= 5.39, < 7"
}
null = {
source = "hashicorp/null"
Expand Down
Loading