Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated Log Group possible retention days #76

Conversation

anbotero
Copy link
Contributor

@anbotero anbotero commented Mar 6, 2025

Description

Some Retention settings were missing and they are now offered by AWS CloudWatch Logs.

Motivation and Context

While working on a HIPAA related project, I tried to setup the retention days to 2192 (6 years), and that’s when I got the validation error:

Must be 1, 3, 5, 7, 14, 30, 60, 90, 120, 150, 180, 365, 400, 545, 731, 1827, 3653 or 0 (zero indicates never expire logs).

The numbers now match against AWS Console and most importantly also with aws_cloudwatch_log_group parameters on AWS Provider.

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

I tested using the Module with both 0 and 2192 values.

  • I have executed pre-commit run -a on my pull request

@anbotero anbotero changed the title chore: update log group possible retention days update log group possible retention days Mar 6, 2025
@anbotero anbotero changed the title update log group possible retention days chore: Update Log Group possible retention days Mar 6, 2025
@antonbabenko antonbabenko changed the title chore: Update Log Group possible retention days fix: Updated Log Group possible retention days Mar 6, 2025
@antonbabenko antonbabenko merged commit ec7e34a into terraform-aws-modules:master Mar 6, 2025
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants