bump(main/libprotobuf): 32.0 #25988
Open
bump(main/libprotobuf): 32.0 #25988
+91
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertkirkman
requested review from
Grimler91,
thunder-coding and
TomJo2000
as code owners
robertkirkman
force-pushed
the
protobuf-32.0
branch
7 times, most recently
from
2ca474c to
316c92f
Compare
- Includes revision-bumps of all reverse dependencies; only one package, `apache-orc`, has a build failure because of newer `libprotobuf`. Its patch is copied and pasted from this PR: apache/orc#2316 - `protobuf-static` is also bumped. It is an orphaned package and there have been, in the past several months since termux#24131, **no known cases of anyone encountering any issues for which they need `protobuf-static` anymore**. This strongly suggests that the **new `libandroid-stub` invented by twaik** that I helped with termux#23712 is probably a completely successful workaround in Android to this upstream `libprotobuf` issue: protocolbuffers/protobuf#5254. However, because the original bug is very rare and only affects a very few Android devices, and among those few Android device where it is reproducible, there are some subtle variations in the content of the protobuf error message, for the time being, I think it is probably a good idea to keep `protobuf-static` unchanged, and eventually, maybe in 1 year from now, if still nobody has ever needed `protobuf-static` at that time, it can be completely disabled.
…UILD" == 'false'` - Kind of reverts termux@84ba1d6 and termux@5fd7eb6 - Unfortunately, those commits appear to break the build of `aapt` in GitHub Actions any time that it is built in the same CI run as any other package that is in `big-pkgs.list`. - Error message: `cp: cannot stat '/usr/local/lib/android/sdk/platforms/android-35/android.jar': No such file or directory` - Lines of code that are related: https://github.com/termux/termux-packages/blob/aa6026e520380b89d479987d763d003425b13b11/scripts/properties.sh#L327 https://github.com/termux/termux-packages/blob/aa6026e520380b89d479987d763d003425b13b11/packages/aapt/build.sh#L238
…es.sh` to fix build for 32-bit targets with `libprotobuf` 32.0
robertkirkman
force-pushed
the
protobuf-32.0
branch
from
316c92f to
66c8d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes revision-bumps of all reverse dependencies; only two packages,
apache-orcandlibosmpbf, have build failures because of newerlibprotobuf.apache-orcpatch is copied and pasted from this PR: [C++] add missing include for protobuf types apache/orc#2316libosmpbfnow needs the helperLDFLAGS+=" $($TERMUX_SCRIPTDIR/packages/libprotobuf/interface_link_libraries.sh)"to build successfully for 32-bit targets when it previously did notprotobuf-staticis also bumped. It is an orphaned package and there have been, in the past several months since tree-wide: migrate all reverse dependencies ofprotobuf-statictolibprotobuf#24131, no known cases of anyone encountering any issues for which they needprotobuf-staticanymore. This strongly suggests that the newlibandroid-stubinvented by twaik that I helped with chore(main/libandroid-stub): turn libandroid-stub into library-wrapper #23712 is probably a completely successful workaround in Android to this upstreamlibprotobufissue: Why libprotobuf.so causing apk crash . protocolbuffers/protobuf#5254. However, because the original bug is very rare and only affects a very few Android devices, and among those few Android device where it is reproducible, there are some subtle variations in the content of the protobuf error message, for the time being, I think it is probably a good idea to keepprotobuf-staticavailable, and eventually, maybe in 1 year from now, if still nobody has ever neededprotobuf-staticat that time, it can be completely disabled.in
.gihub/workflows/packages.yml,unsetNDKandANDROID_HOMEif"$DOCKER_BUILD" == 'false'Kind of partly reverts 84ba1d6 and 5fd7eb6
Unfortunately, those commits appear to break the build of
aaptin GitHub Actions any time that it is built in the same CI run as another package if that other package is inbig-pkgs.list.Error message:
cp: cannot stat '/usr/local/lib/android/sdk/platforms/android-35/android.jar': No such file or directoryLines of code that are related:
termux-packages/scripts/properties.sh
Line 327 in aa6026e
termux-packages/packages/aapt/build.sh
Line 238 in aa6026e