Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to esm #860

Merged
merged 16 commits into from
Jul 2, 2024
Merged

Migrate to esm #860

merged 16 commits into from
Jul 2, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Jun 26, 2024

This PR makes the following changes:

@sotojn sotojn self-assigned this Jun 26, 2024
@sotojn sotojn requested a review from jsnoble June 27, 2024 16:16
@sotojn
Copy link
Contributor Author

sotojn commented Jun 29, 2024

This issue has validation that this asset is working correctly: #861

@sotojn sotojn marked this pull request as ready for review July 1, 2024 14:55
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The move to switch out pulling types from job-components to the types package is not fully needed now as it has been refactored and the types of the two libraries work with each other now but its ok, the only thing is the commented out code left in

jest.config.js Outdated Show resolved Hide resolved
@jsnoble jsnoble merged commit 4ef1c89 into master Jul 2, 2024
4 checks passed
@jsnoble jsnoble deleted the migrate-to-esm branch July 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants