Disable the web plugin on macOS
#4159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
maintenance
dominiklohmann
force-pushed
the
topic/disable-web-plugin-macos
branch
from
af98547
to
2eda569
Compare
jachris
approved these changes
Apr 25, 2024
dominiklohmann
force-pushed
the
topic/disable-web-plugin-macos
branch
2 times, most recently
from
c990363
to
bef1507
Compare
The Homebrew package for its http parser dependency was disabled quite a while ago because the library is unmaintained and no longer compiled from source against our current compiler toolchain, so it's really hard to build the `web` plugin on macOS. This just disables it. This also re-enables the `parquet` plugin on macOS, as that no longer uses illegal instruction as far as I can tell.
dominiklohmann
force-pushed
the
topic/disable-web-plugin-macos
branch
from
bef1507
to
b4039c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Homebrew package for its http parser dependency was disabled quite a while ago because the library is unmaintained and no longer compiled from source against our current compiler toolchain, so it's really hard to build the
webplugin on macOS. This just disables it.This also re-enables the
parquetplugin on macOS, as that no longer uses illegal instruction as far as I can tell.