-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve issue #176 #177
Closed
Closed
resolve issue #176 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the argument is named TENSORFLOW_NOTEBOOK_DIR and defaults to /home/tf_user/notebooks
Run script setup.tensorflow.user.sh to create TENSORFLOW_USER and TENSORFLOW_GROUP. Make sure TENSORFLOW_USER owns his home directory and TENSORFLOW_NOTEBOOK_DIR. To run jupyter as TENSORFLOW_USER it is neccessary to split the python and jupyter setup properly: All the apt stuff must be done as root and all the pip stuff must be done as TENSORFLOW_USER. Once this is done, we can do a "USER=${TENSORFLOW_USER} before we run jupyter.
Now setup.jupyter can be run as non-root user.
The entire installation of jupyter and tensorflow is done as ${TENSORFLOW_USER} with pip. Folder /home/${TENSORFLOW_USER}/.local/bin is added to the environment variable PATH. A notebook folder /home/${TENSORFLOW_USER}/notebooks is created and the tutorials are install in this folder. Finally the command source /etc/bash.bashrc && jupyter notebook --notebook-dir=${TENSORFLOW_NOTEBOOK_DIR} --ip 0.0.0.0 --no-browser --allow-root is run as TENSORFLOW_USER. The only thing still bothering me is the call to ldconfig in /etc/bash.bashrc. I don't understand why we need this. And it can't be done as non-root user.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entire installation of jupyter and tensorflow is done as user
${TENSORFLOW_USER} with pip. Folder /home/${TENSORFLOW_USER}/.local/bin
is added to the environment variable PATH. A notebook folder
/home/${TENSORFLOW_USER}/notebooks is created and the tutorials
are installed in this folder.
Finally the command
is run as TENSORFLOW_USER.
The only thing still bothering me is the call to ldconfig in /etc/bash.bashrc.
I don't understand why we need this. And it can't be done as non-root user.