Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable UNLOGGED vector indexes #443

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

usamoi
Copy link
Collaborator

@usamoi usamoi commented Mar 22, 2024

  • It looks that there is no way to support unlogged indexes without writing to PostgreSQL storage. I'm not confident about accessing PostgreSQL storage: it's easy to make it bugful. So let's remove support for UNLOGGED indexes.
  • fix security issues if running pgvectors_upgrade when everything is OKay
  • fix memory leak (< 1 KB) caused by as_pg_cstr

@usamoi usamoi requested a review from cutecutecat March 22, 2024 08:19
@usamoi usamoi added this pull request to the merge queue Mar 22, 2024
Merged via the queue into tensorchord:main with commit 0056d67 Mar 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant