Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optimizing_threads to function #375

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

cutecutecat
Copy link
Member

@cutecutecat cutecutecat commented Feb 21, 2024

Fix #195

Add a new function select alter_vector_index("t_idx", 'optimizing.optimizing_threads', 100); to alter index.

@cutecutecat cutecutecat force-pushed the opt-thread branch 5 times, most recently from 38932e5 to 1a0649e Compare February 27, 2024 02:38
@cutecutecat cutecutecat requested a review from usamoi February 27, 2024 03:19
@cutecutecat cutecutecat marked this pull request as ready for review February 27, 2024 03:19
crates/base/src/index.rs Outdated Show resolved Hide resolved
crates/service/src/index/mod.rs Outdated Show resolved Hide resolved
crates/service/src/index/optimizing/indexing.rs Outdated Show resolved Hide resolved
src/index/views.rs Outdated Show resolved Hide resolved
src/index/views.rs Outdated Show resolved Hide resolved
@cutecutecat cutecutecat force-pushed the opt-thread branch 2 times, most recently from 62d875e to 80c326a Compare February 28, 2024 08:58
@cutecutecat cutecutecat marked this pull request as draft February 28, 2024 08:58
@cutecutecat
Copy link
Member Author

This PR will be blocking until #314 handler Oid implemented.

@cutecutecat cutecutecat force-pushed the opt-thread branch 6 times, most recently from d9b7496 to e3f9737 Compare February 28, 2024 13:20
@usamoi usamoi marked this pull request as ready for review March 13, 2024 07:14
@usamoi
Copy link
Collaborator

usamoi commented Mar 13, 2024

Please resolve conflicts.

@cutecutecat cutecutecat force-pushed the opt-thread branch 4 times, most recently from ba694f3 to cd2a473 Compare March 21, 2024 08:03
@cutecutecat cutecutecat requested a review from usamoi March 22, 2024 01:34
crates/base/src/index.rs Outdated Show resolved Hide resolved
crates/index/src/lib.rs Outdated Show resolved Hide resolved
crates/index/src/setting.rs Outdated Show resolved Hide resolved
crates/index/src/setting.rs Outdated Show resolved Hide resolved
@cutecutecat cutecutecat force-pushed the opt-thread branch 2 times, most recently from 4338947 to 4523276 Compare March 25, 2024 01:19
@cutecutecat cutecutecat force-pushed the opt-thread branch 2 times, most recently from d1e25fb to f6a7a64 Compare March 25, 2024 03:35
Signed-off-by: cutecutecat <[email protected]>
src/ipc/mod.rs Outdated Show resolved Hide resolved
crates/base/src/index.rs Outdated Show resolved Hide resolved
crates/base/src/index.rs Outdated Show resolved Hide resolved
crates/index/src/lib.rs Outdated Show resolved Hide resolved
crates/index/src/lib.rs Outdated Show resolved Hide resolved
crates/index/src/lib.rs Outdated Show resolved Hide resolved
Signed-off-by: cutecutecat <[email protected]>
Copy link
Collaborator

@usamoi usamoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accepting anyelement or json may be better

@cutecutecat cutecutecat added this pull request to the merge queue Mar 26, 2024
Merged via the queue into tensorchord:main with commit e18616b Mar 26, 2024
11 checks passed
@VoVAllen
Copy link
Member

Please raise a doc issue in doc repo for tracking

silver-ymz added a commit to silver-ymz/pgvecto.rs that referenced this pull request Apr 2, 2024
JinweiOS pushed a commit to JinweiOS/pgvecto.rs that referenced this pull request May 21, 2024
* feat: add optiming_threads to index

Signed-off-by: cutecutecat <[email protected]>

* put flexible at IndexProtect

Signed-off-by: cutecutecat <[email protected]>

* fix by comments

Signed-off-by: cutecutecat <[email protected]>

---------

Signed-off-by: cutecutecat <[email protected]>
Signed-off-by: jinweios <[email protected]>
@cutecutecat cutecutecat deleted the opt-thread branch September 2, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Configure optimizing thread in runtime
3 participants